Closed ebousse closed 3 years ago
the new component should also be added to the feature.xml files and probably in the resulting studio (UI or headless)
the new component should also be added to the feature.xml files
Good point. I've pushed the updated feature.xml
and probably in the resulting studio (UI or headless)
I'm looking at all feature.xml
files from the gemoc-studio repo, and if I'm correct only the headless version is directly pointing to specific plugins, while other ones are pointing to features, right?
this is right, the UI ide uses feature dependencies, while the headless one tries to minimize the size by using plugin dependencies only.
and actually double checking the features I'm surprised with https://github.com/eclipse/gemoc-studio/blob/master/gemoc_studio/releng/org.eclipse.gemoc.gemoc_studio.branding.feature/feature.xml : it doesn't contains an explicit depedency to a "root" feature for the content of https://github.com/eclipse/gemoc-studio-execution-java (it probablbly get the plugins inderectly via the sample deployer ...)
The last commit did the trick, the CI seems now OK − despite the same 2 test cases still failing since a while. I've also tested locally that the new resulting studio fixes the compilation problem from https://github.com/eclipse/gemoc-studio-execution-java/pull/17. Let's merge.
Description
Fixes several little oversights from the previous PR(#187), in particular a missing
<module>
declaration in the rightpom.xml
, which meant that the code from PR #187 was actually never compiled by the CI.Changes
framework/execution_framework/plugins/pom.xml
org.eclipse.gemoc.executionframework.feature/feature.xml
org.eclipse.gemoc.executionframework.event.manager/build.properties