search

eclipse / ice

This project has moved to: https://gitlab.eclipse.org/eclipse/ice/ice
https://gitlab.eclipse.org/eclipse/ice/ice
Eclipse Public License 1.0
30 stars 55 forks source link

Create new build system and move commands tests #452

Closed gecage952 closed 4 years ago

gecage952 commented 4 years ago

This pr helps cover issues #437 and #446. The commands tests that required external resources are now in org.eclipse.ice.tests.integration . As for the builder, by going into org.eclipse.ice.builder and running "mvn install," it should build the parent, dev, archetypes, and commands projects.

osbornjd commented 4 years ago

I'll take a look at this tomorrow morning - others should feel free as well but I want to make sure all of the tests that needed moving got moved and make sure the tests pass etc.

gecage952 commented 4 years ago 
1. I think the name builder is not correct. To me that speaks to the builder pattern, which is something we may end up with a project on. I would think just "build" would be the correct suffix: org.eclipse.ice.build.

Yeah, I agree that is a much better name. I was little bit unsure about "builder," but I figured we could just change it. I'll go ahead and change it to that (org.eclipse.ice.build) if no one has any problems with that.

osbornjd commented 4 years ago

Open question: Is it better to have the instructions for running the integration tests for each project in that folder in the folders themselves or pulled out into a central README at the top of tests.integration? If not pulled out, should we have that central README link to the project specific README files?

@jayjaybillings I was thinking about this too, as I created an issue to update the READMEs for commands now that things are moved around/separated. My opinion is that we should have the central README link to the project specific READMEs, with maybe a blurb about each project in the central README. The reason I feel this way is that I find that sometimes READMEs can get overly complex/dense/verbose, so helping people navigate to what they are actually looking for would be useful.

osbornjd commented 4 years ago

All changes have been addressed, so I think we can merge this. Thanks @gecage952!