Closed jayjaybillings closed 2 years ago
@jonahkichwacoders Given your recent experience with xtext in CDT as you mentioned in #58, any thoughts on this?
I'll note too that you mentioned in #58 that January is data and algorithms, which is inline with number 1 above. What do you do with all the UI stuff from xtext in CDT? (If you even use it...)
The Xtext bundles are well split between core/ui. The core plugin + tests (the ones without .ide or .ui) are true core ones (not even requiring OSGi, let along workbench or UI). In CDT, the Linker Script is one self-contained feature with core and ui plug-ins.
At the moment it would seem to me that the ui and ide plug-ins don't really belong in January. It seems that EAVP provides one set of UI to operate on these models, and at the moment they are derived from the auto-generated Xtext ones.
A related question, that would help me understand better is: what does o.e.j.geometry.* aim to provide? Reading and serialization of models? Processing of them? Algorithms on them? etc. With o.e.j.form + dataset it is much more obvious.
I think that 1 should stay in January. I think there is a good argument to be made that 3 could stay as well. I think 2 & 4 should go back to EAVP.
Any thoughts?
Closing as january-forms was moved to https://github.com/eclipse/january-forms
I wanted to put a specific ticket in to talk about cleaning up this xtext/emf generated code org.eclipse.january.geometry. I'm sure @gerring will respond with "just remove it," especially since I've prodded him! ;-)
N.B. - The VTK bundles are very messed up and need to be reworked. There's some dirty code in there and I'm not sure how it snuck in.
The original goal of creating bundles like org.eclipse.january.geometry.{iges,mtl,obj,vtk} was to extend the geometry data model for 3D geometries to support the IGES, MTL, OBJ and VTK file formats. Each plugin provides extensions to the model, importers and exports, and graphical editors, all of which is managed by EMF magic. All of the "core" data structures for geometry are provided in org.eclipse.january.geometry. All of the org.eclipse.january.geometry.xtext.* bundles provide extensions as described above.
I can see arguing how to deal with this in two ways:
I put this ticket up because I want to engage the community in how this is fixed. Any thoughts? Any other ways to deal with this? (A possible third option could be what Jonah suggested in his email about extra repos, for example.)