search

eclipse / jbom

Apache License 2.0
111 stars 5 forks source link

Significant improvements to pom, plus minor code improvements. #15

Closed davewichers closed 1 year ago

davewichers commented 1 year ago

In the pom: upgrade all libs/plugins to their latest versions. Add missing libraries (used/undeclared) and remove unused ones (declared/unused). Add a bunch of default maven plugins so we can upgrade them. Add some basic reporting capabilities when using mvn site. Add some additional pom attributes like name, project description, license, etc.

In the code, organize some imports. Update the jbom version written to the generated SBOM so it outputs the actual version of jbom, not the static value 1.0.0. And point the project repo to the Eclipse foundation web site.

planetlevel commented 1 year ago

Thank you Dave. Some nice changes in here. The jdom stuff is broken though. Throws NPE every time. Also you don't need anything in the pom to get resources directory contents into jar file -- happens automatically. I made some updates and checked in. Let me know when you get a chance to test and I'll do a release.

davewichers commented 1 year ago

@planetlevel - The merge plus the changes you made after look good to me.