eclipse / jifa

🔬 Online Heap Dump, GC Log, Thread Dump & JFR File Analyzer.
https://eclipse.github.io/jifa/
Eclipse Public License 2.0
543 stars 96 forks source link

UI improvement, User can specify more options at memory dump analysis scene & changing setting is cancelable after open the settings pannel. #242

Closed XuPengfei-1020 closed 11 months ago

XuPengfei-1020 commented 1 year ago

1. User can specify more options at memory dump analysis scene.

Analyse could be faild caused by OOM(exceed limit of maximum length of array) if the dump file is very large. This problem can be solved by specify discard-object options. see: Eclipse help . Improve UI so user can specify those options.

2. UI improvement, user can cancel changing the settings (re-analysis dump file) after they open the setting panel in dump analysis scene.

before: dump analysis cache will dispose once user click 'Setting' button, it does not make sense. now: dispose and re-analyse will performd sequencely only after use submit the new settings, but if user click the 'cancel' button after open the settins pannel, the pannel will closed and nothing else would happend.

XuPengfei-1020 commented 1 year ago
  1. Support more options.

    image image
  2. Add cancel button, user can cancel re-analyze if they want.

    image
D-D-H commented 12 months ago

@XuPengfei-1020 Thanks for the contribution. Please sign the eca.

I'll review this patch this week.

XuPengfei-1020 commented 11 months ago

Update:

We used the jifa to parse the super large dump files on linux server several times, it helpe us to location the rare memory lake point in our production environment. Thinks! Great tool!

D-D-H commented 11 months ago

Merged. Thanks for the contribution.