eclipse / jifa

🔬 Online Heap Dump, GC Log, Thread Dump & JFR File Analyzer.
https://eclipse.github.io/jifa/
Eclipse Public License 2.0
541 stars 96 forks source link

feature: add worker image pull secret name #273

Closed wcp1231 closed 8 months ago

wcp1231 commented 8 months ago

Hi, all

Could I have a review for this patch. I would be very grateful.

The official image is out of date, so I built an image and pushed it to our private registry, then found that it needs set pull secret to pull the elastic worker image from the private registry.

This patch adds the image-pull-secret-name option to the master node so that it can pull image from the private registry when scheduling a worker pod.

Thanks

D-D-H commented 8 months ago

Please sign the eca.

Thanks!

wcp1231 commented 8 months ago

The change looks good to me.

Please update the doc located at:

Okay, I've updated the doc and sign the eca.

D-D-H commented 8 months ago

Thanks for the contribution.

I updated the commit title ('feature' -> 'feat') to keep consistent.