search

eclipse / jifa

🔬 Online Heap Dump, GC Log, Thread Dump & JFR File Analyzer.
https://eclipse.github.io/jifa/
Eclipse Public License 2.0
543 stars 96 forks source link

Typo in GC Log parser #285

Closed MatthewKhouzam closed 5 months ago

MatthewKhouzam commented 5 months ago

analysis/gc-log/src/main/java/org/eclipse/jifa/gclog/event/evnetInfo should be analysis/gc-log/src/main/java/org/eclipse/jifa/gclog/event/eventInfo

I know GitHub issues is not a social network, but I should introduce myself. I'm Matthew, an Eclipse Trace Compass developer. I was looking into adding a GC parser to enhance tc's experience and found that there was already one in the foundation. I would like to collaborate with you.

D-D-H commented 5 months ago

analysis/gc-log/src/main/java/org/eclipse/jifa/gclog/event/evnetInfo should be analysis/gc-log/src/main/java/org/eclipse/jifa/gclog/event/eventInfo

We'll fix it.

I know GitHub issues is not a social network, but I should introduce myself. I'm Matthew, an Eclipse Trace Compass developer. I was looking into adding a GC parser to enhance tc's experience and found that there was already one in the foundation. I would like to collaborate with you.

Happy to hear that. Would you happen to have any ideas about the form of cooperation?

MatthewKhouzam commented 5 months ago

Happy to hear that. Would you happen to have any ideas about the form of cooperation?

Here is a code example. https://github.com/eclipse-tracecompass-incubator/org.eclipse.tracecompass.incubator/pull/37

Trace Compass has a lot of metrics and being able to correlate OS issues with GC events and freezes in the java application is very useful for us. Maybe we can discuss ways that the two tools can work together.

D-D-H commented 5 months ago

Maybe we can discuss ways that the two tools can work together.

I took a quick look at the example you provided, and my initial feeling is that Jifa can provide a third-party analysis library for gc logs (in fact, other users have made similar requests), so that you can directly rely on it in your project.

D-D-H commented 5 months ago

Jifa currently relies on a minimum JDK version of 17, but from an implementation perspective, we can relax this restriction for the gc log analysis module.

MatthewKhouzam commented 5 months ago

JDK 17 is just fine.

The way I see it, trace compass is about parsing N sources of data and putting them on a timeline. Jifa is about investigating java issues from a developer perspective.

I do not want jifa to depend on tc. I want TC to be able to consume from Jifa, or the external gc log as you suggested, but I would especially like to share experieneces/war stories/workflows with you guys. Let's face it, when people get together and write 100k+ of java code, it's not just for fun. We probably have some hidden business value we can find.

I tried joining the slack and was rejected. I think it wasn't set up right.

I think we can close this bug though.

I will open two new ones with feature requests:

D-D-H commented 5 months ago

Jifa's Slack channel has not been used for a while since there aren't many active developers:-(

MatthewKhouzam commented 5 months ago

Gotcha. Are you in an eclipse working group? that can help pool resources.

D-D-H commented 5 months ago

Are you in an eclipse working group?

If I remember correctly, I am not in any working groups.

Feel free to file Git issues or PRs, which may be our best current channel.

MatthewKhouzam commented 5 months ago

I have the privilege of chairing the eclipse cloud development tools working group. I know people in the IDE working group too. https://ecdtools.eclipse.org/. Mind you, a solution that works for me is not necessarily a solution that works for you. I would like more people to know about JIFA in the community though. I feel we can close this issue. Thank you for the great product btw!