eclipse / jifa

🔬 Online Heap Dump, GC Log, Thread Dump & JFR File Analyzer.
https://eclipse.github.io/jifa/
Eclipse Public License 2.0
541 stars 96 forks source link

The static worker node obtained the IP address 127.0.0.1 #305

Closed mycxu closed 1 month ago

mycxu commented 1 month ago

I am attempting to deploy a static cluster, and when I start the static worker node, I noticed that the IP address saved in the static_workers table is 127.0.0.1. I noticed that in the CurrentStaticWorker.java,the IP address of the static worker node is obtained using the following method:

InetAddress localHost = InetAddress.getLocalHost(); 
String hostAddress = localHost.getHostAddress();

However, this does not seem to be a reliable, system-independent method.It attempts to obtain the local IP address by resolving the hostname, and in most cases, the hostname is set to localhost. I was able to obtain the correct IP address by using the NetworkInterface class. Would it be a better approach to change my system configuration so that localHost.getHostAddress() returns the correct IP address?

D-D-H commented 1 month ago

Would it be a better approach to change my system configuration so that localHost.getHostAddress() returns the correct IP address?

Yes. Would you like to submit a PR for this problem?

mycxu commented 1 month ago

Would you like to submit a PR for this problem?

If we choose to modify the system configuration, we just need to ensure that the "hostname" in /etc/hosts resolves to the IP address we want, so this does not involve any code changes. However, I saw that JCS also encountered this issue and similarly addressed it by using NetworkInterfaceto obtain the correct IP address. It is considered that using NetworkInterface might be a more appropriate method. Do you think we need to modify the code to resolve this problem? If so, I can submit a PR.

D-D-H commented 1 month ago

Yes, let's use NetworkInterface instead.

We need to consider how to process if multiple addresses are available.

mycxu commented 1 month ago

PR: #306