search

eclipse / kapua

Eclipse Public License 2.0
225 stars 160 forks source link

:fix: avoid npe on unknown domain #3972

Closed dseurotech closed 8 months ago

dseurotech commented 8 months ago

Fix for a corner case regarding groupable permissions check potentially failing (in tests) due placeholder domain not being present.

codecov[bot] commented 8 months ago

Codecov Report

Attention: 1 lines in your changes are missing coverage. Please review.

Comparison is base (60e6b95) 21.16% compared to head (1f00b46) 21.16%.

Additional details and impacted files [![Impacted file tree graph](https://app.codecov.io/gh/eclipse/kapua/pull/3972/graphs/tree.svg?width=650&height=150&src=pr&token=1P4N4CApH8&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=eclipse)](https://app.codecov.io/gh/eclipse/kapua/pull/3972?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=eclipse) ```diff @@ Coverage Diff @@ ## develop #3972 +/- ## ========================================== Coverage 21.16% 21.16% Complexity 10 10 ========================================== Files 1940 1940 Lines 41246 41246 Branches 3790 3790 ========================================== Hits 8730 8730 Misses 32109 32109 Partials 407 407 ``` | [Files](https://app.codecov.io/gh/eclipse/kapua/pull/3972?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=eclipse) | Coverage Δ | | |---|---|---| | [...vice/authorization/shiro/PermissionMapperImpl.java](https://app.codecov.io/gh/eclipse/kapua/pull/3972?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=eclipse#diff-c2VydmljZS9zZWN1cml0eS9zaGlyby9zcmMvbWFpbi9qYXZhL29yZy9lY2xpcHNlL2thcHVhL3NlcnZpY2UvYXV0aG9yaXphdGlvbi9zaGlyby9QZXJtaXNzaW9uTWFwcGVySW1wbC5qYXZh) | `4.12% <0.00%> (ø)` | |