search

eclipse / kapua

Eclipse Public License 2.0
222 stars 160 forks source link

FEATURE - Added the "status" query parameter for api endpoint "/{scopeId}/jobs/{jobId}/targets" #4002

Closed Agnul97 closed 5 months ago

Agnul97 commented 5 months ago

Brief description of the PR. It is now possible to filter job targets based on the "jobTargetStatus" field

Besides, with this change:

Screenshot 2024-03-22 at 14 49 10

I fixed a problem where the predicate of the query to this endpoint "/{scopeId}/jobs/{jobId}/targets" was substituted by the predicate set in the "query" method of this class (see line 131 where _query.setPredicate(query.attributePredicate(JobTargetAttributes.JOBID, jobId))

codecov[bot] commented 5 months ago

Codecov Report

Attention: Patch coverage is 0% with 5 lines in your changes are missing coverage. Please review.

Project coverage is 21.08%. Comparing base (aa54cb7) to head (3a3a041). Report is 10 commits behind head on develop.

Additional details and impacted files [![Impacted file tree graph](https://app.codecov.io/gh/eclipse/kapua/pull/4002/graphs/tree.svg?width=650&height=150&src=pr&token=1P4N4CApH8&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=eclipse)](https://app.codecov.io/gh/eclipse/kapua/pull/4002?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=eclipse) ```diff @@ Coverage Diff @@ ## develop #4002 +/- ## ============================================= - Coverage 21.08% 21.08% -0.01% Complexity 10 10 ============================================= Files 1947 1953 +6 Lines 41397 41423 +26 Branches 3805 3801 -4 ============================================= + Hits 8730 8733 +3 - Misses 32263 32286 +23 Partials 404 404 ``` | [Files](https://app.codecov.io/gh/eclipse/kapua/pull/4002?dropdown=coverage&src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=eclipse) | Coverage Δ | | |---|---|---| | [...pua/app/api/resources/v1/resources/JobTargets.java](https://app.codecov.io/gh/eclipse/kapua/pull/4002?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=eclipse#diff-cmVzdC1hcGkvcmVzb3VyY2VzL3NyYy9tYWluL2phdmEvb3JnL2VjbGlwc2Uva2FwdWEvYXBwL2FwaS9yZXNvdXJjZXMvdjEvcmVzb3VyY2VzL0pvYlRhcmdldHMuamF2YQ==) | `0.00% <0.00%> (ø)` | | ... and [15 files with indirect coverage changes](https://app.codecov.io/gh/eclipse/kapua/pull/4002/indirect-changes?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=eclipse)