eclipse / kapua

Eclipse Public License 2.0
222 stars 160 forks source link

:fix: Fix service client ack mode #4008

Closed riccardomodanese closed 5 months ago

riccardomodanese commented 5 months ago

Brief description of the PR. Changed the session acknowledge from CLIENT_ACKNOWLEDGE to AUTO since the client doesn't ACK any message. This is causing messages accumulation on service broker side and lead to a crash

Related Issue none

Description of the solution adopted See the brief descrition

Screenshots none

Any side note on the changes made none

codecov[bot] commented 5 months ago

Codecov Report

Attention: Patch coverage is 0% with 11 lines in your changes are missing coverage. Please review.

Project coverage is 16.87%. Comparing base (3025da1) to head (52d50b0).

Additional details and impacted files [![Impacted file tree graph](https://app.codecov.io/gh/eclipse/kapua/pull/4008/graphs/tree.svg?width=650&height=150&src=pr&token=1P4N4CApH8&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=eclipse)](https://app.codecov.io/gh/eclipse/kapua/pull/4008?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=eclipse) ```diff @@ Coverage Diff @@ ## develop #4008 +/- ## ============================================= - Coverage 21.09% 16.87% -4.22% Complexity 10 10 ============================================= Files 1954 1989 +35 Lines 41430 51787 +10357 Branches 3801 4420 +619 ============================================= Hits 8739 8739 - Misses 32287 42644 +10357 Partials 404 404 ``` | [Files](https://app.codecov.io/gh/eclipse/kapua/pull/4008?dropdown=coverage&src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=eclipse) | Coverage Δ | | |---|---|---| | [...lipse/kapua/client/security/amqpclient/Client.java](https://app.codecov.io/gh/eclipse/kapua/pull/4008?src=pr&el=tree&filepath=client%2Fsecurity%2Fsrc%2Fmain%2Fjava%2Forg%2Feclipse%2Fkapua%2Fclient%2Fsecurity%2Famqpclient%2FClient.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=eclipse#diff-Y2xpZW50L3NlY3VyaXR5L3NyYy9tYWluL2phdmEvb3JnL2VjbGlwc2Uva2FwdWEvY2xpZW50L3NlY3VyaXR5L2FtcXBjbGllbnQvQ2xpZW50LmphdmE=) | `0.00% <0.00%> (ø)` | | | [...a/broker/artemis/plugin/security/ServerPlugin.java](https://app.codecov.io/gh/eclipse/kapua/pull/4008?src=pr&el=tree&filepath=broker%2Fartemis%2Fplugin%2Fsrc%2Fmain%2Fjava%2Forg%2Feclipse%2Fkapua%2Fbroker%2Fartemis%2Fplugin%2Fsecurity%2FServerPlugin.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=eclipse#diff-YnJva2VyL2FydGVtaXMvcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2VjbGlwc2Uva2FwdWEvYnJva2VyL2FydGVtaXMvcGx1Z2luL3NlY3VyaXR5L1NlcnZlclBsdWdpbi5qYXZh) | `0.00% <0.00%> (ø)` | | | [...broker/artemis/plugin/security/SecurityPlugin.java](https://app.codecov.io/gh/eclipse/kapua/pull/4008?src=pr&el=tree&filepath=broker%2Fartemis%2Fplugin%2Fsrc%2Fmain%2Fjava%2Forg%2Feclipse%2Fkapua%2Fbroker%2Fartemis%2Fplugin%2Fsecurity%2FSecurityPlugin.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=eclipse#diff-YnJva2VyL2FydGVtaXMvcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2VjbGlwc2Uva2FwdWEvYnJva2VyL2FydGVtaXMvcGx1Z2luL3NlY3VyaXR5L1NlY3VyaXR5UGx1Z2luLmphdmE=) | `0.00% <0.00%> (ø)` | | | [.../artemis/plugin/security/metric/PublishMetric.java](https://app.codecov.io/gh/eclipse/kapua/pull/4008?src=pr&el=tree&filepath=broker%2Fartemis%2Fplugin%2Fsrc%2Fmain%2Fjava%2Forg%2Feclipse%2Fkapua%2Fbroker%2Fartemis%2Fplugin%2Fsecurity%2Fmetric%2FPublishMetric.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=eclipse#diff-YnJva2VyL2FydGVtaXMvcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2VjbGlwc2Uva2FwdWEvYnJva2VyL2FydGVtaXMvcGx1Z2luL3NlY3VyaXR5L21ldHJpYy9QdWJsaXNoTWV0cmljLmphdmE=) | `0.00% <0.00%> (ø)` | | ... and [35 files with indirect coverage changes](https://app.codecov.io/gh/eclipse/kapua/pull/4008/indirect-changes?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=eclipse)