eclipse / kapua

Eclipse Public License 2.0
222 stars 160 forks source link

Ref inter dependencies cleanup #4017

Open dseurotech opened 5 months ago

dseurotech commented 5 months ago

This PR intends to clean up the internal dependencies between kapua modules. In most cases, it just cleans up the pom.xml files from dependencies which are already received transitively via maven (e.g.: if you already depend on the -internal module, it is implicit the dependence from the -api module). In a few cases data classes have been moved closer to the project that use them -e.g.: IsJobRunningMultipleResponse.java is specific to the job engine and does not need to be in the commons-rest-model module.

codecov-commenter commented 4 months ago

Codecov Report

Attention: Patch coverage is 23.28767% with 56 lines in your changes missing coverage. Please review.

Project coverage is 16.80%. Comparing base (296efcd) to head (5622379).

Additional details and impacted files [![Impacted file tree graph](https://app.codecov.io/gh/eclipse/kapua/pull/4017/graphs/tree.svg?width=650&height=150&src=pr&token=1P4N4CApH8&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=eclipse)](https://app.codecov.io/gh/eclipse/kapua/pull/4017?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=eclipse) ```diff @@ Coverage Diff @@ ## develop #4017 +/- ## ========================================== Coverage 16.79% 16.80% Complexity 22 22 ========================================== Files 2008 2007 -1 Lines 52210 52190 -20 Branches 4399 4395 -4 ========================================== Hits 8770 8770 + Misses 43044 43022 -22 - Partials 396 398 +2 ``` | [Files](https://app.codecov.io/gh/eclipse/kapua/pull/4017?dropdown=coverage&src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=eclipse) | Coverage Δ | | |---|---|---| | [...clipse/kapua/client/security/bean/AuthContext.java](https://app.codecov.io/gh/eclipse/kapua/pull/4017?src=pr&el=tree&filepath=client%2Fsecurity%2Fsrc%2Fmain%2Fjava%2Forg%2Feclipse%2Fkapua%2Fclient%2Fsecurity%2Fbean%2FAuthContext.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=eclipse#diff-Y2xpZW50L3NlY3VyaXR5L3NyYy9tYWluL2phdmEvb3JnL2VjbGlwc2Uva2FwdWEvY2xpZW50L3NlY3VyaXR5L2JlYW4vQXV0aENvbnRleHQuamF2YQ==) | `0.00% <ø> (ø)` | | | [...se/kapua/commons/jpa/KapuaEntityJpaRepository.java](https://app.codecov.io/gh/eclipse/kapua/pull/4017?src=pr&el=tree&filepath=commons%2Fsrc%2Fmain%2Fjava%2Forg%2Feclipse%2Fkapua%2Fcommons%2Fjpa%2FKapuaEntityJpaRepository.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=eclipse#diff-Y29tbW9ucy9zcmMvbWFpbi9qYXZhL29yZy9lY2xpcHNlL2thcHVhL2NvbW1vbnMvanBhL0thcHVhRW50aXR5SnBhUmVwb3NpdG9yeS5qYXZh) | `7.08% <ø> (ø)` | | | [...umer/lifecycle/listener/DeviceMessageListener.java](https://app.codecov.io/gh/eclipse/kapua/pull/4017?src=pr&el=tree&filepath=consumer%2Flifecycle%2Fsrc%2Fmain%2Fjava%2Forg%2Feclipse%2Fkapua%2Fconsumer%2Flifecycle%2Flistener%2FDeviceMessageListener.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=eclipse#diff-Y29uc3VtZXIvbGlmZWN5Y2xlL3NyYy9tYWluL2phdmEvb3JnL2VjbGlwc2Uva2FwdWEvY29uc3VtZXIvbGlmZWN5Y2xlL2xpc3RlbmVyL0RldmljZU1lc3NhZ2VMaXN0ZW5lci5qYXZh) | `0.00% <ø> (ø)` | | | [...apua/service/camel/converter/KapuaCamelFilter.java](https://app.codecov.io/gh/eclipse/kapua/pull/4017?src=pr&el=tree&filepath=service%2Fcamel%2Fsrc%2Fmain%2Fjava%2Forg%2Feclipse%2Fkapua%2Fservice%2Fcamel%2Fconverter%2FKapuaCamelFilter.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=eclipse#diff-c2VydmljZS9jYW1lbC9zcmMvbWFpbi9qYXZhL29yZy9lY2xpcHNlL2thcHVhL3NlcnZpY2UvY2FtZWwvY29udmVydGVyL0thcHVhQ2FtZWxGaWx0ZXIuamF2YQ==) | `0.00% <ø> (ø)` | | | [...thorization/access/shiro/GroupQueryHelperImpl.java](https://app.codecov.io/gh/eclipse/kapua/pull/4017?src=pr&el=tree&filepath=service%2Fsecurity%2Fshiro%2Fsrc%2Fmain%2Fjava%2Forg%2Feclipse%2Fkapua%2Fservice%2Fauthorization%2Faccess%2Fshiro%2FGroupQueryHelperImpl.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=eclipse#diff-c2VydmljZS9zZWN1cml0eS9zaGlyby9zcmMvbWFpbi9qYXZhL29yZy9lY2xpcHNlL2thcHVhL3NlcnZpY2UvYXV0aG9yaXphdGlvbi9hY2Nlc3Mvc2hpcm8vR3JvdXBRdWVyeUhlbHBlckltcGwuamF2YQ==) | `16.12% <ø> (ø)` | | | [.../org/eclipse/kapua/kura/simulator/topic/Topic.java](https://app.codecov.io/gh/eclipse/kapua/pull/4017?src=pr&el=tree&filepath=simulator-kura%2Fsrc%2Fmain%2Fjava%2Forg%2Feclipse%2Fkapua%2Fkura%2Fsimulator%2Ftopic%2FTopic.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=eclipse#diff-c2ltdWxhdG9yLWt1cmEvc3JjL21haW4vamF2YS9vcmcvZWNsaXBzZS9rYXB1YS9rdXJhL3NpbXVsYXRvci90b3BpYy9Ub3BpYy5qYXZh) | `17.58% <ø> (ø)` | | | [...rvice/account/xml/AccountParentPathXmlAdapter.java](https://app.codecov.io/gh/eclipse/kapua/pull/4017?src=pr&el=tree&filepath=service%2Faccount%2Fapi%2Fsrc%2Fmain%2Fjava%2Forg%2Feclipse%2Fkapua%2Fservice%2Faccount%2Fxml%2FAccountParentPathXmlAdapter.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=eclipse#diff-c2VydmljZS9hY2NvdW50L2FwaS9zcmMvbWFpbi9qYXZhL29yZy9lY2xpcHNlL2thcHVhL3NlcnZpY2UvYWNjb3VudC94bWwvQWNjb3VudFBhcmVudFBhdGhYbWxBZGFwdGVyLmphdmE=) | `90.90% <89.47%> (-9.10%)` | :arrow_down: | | [...pse/kapua/commons/service/internal/ServiceDAO.java](https://app.codecov.io/gh/eclipse/kapua/pull/4017?src=pr&el=tree&filepath=commons%2Fsrc%2Fmain%2Fjava%2Forg%2Feclipse%2Fkapua%2Fcommons%2Fservice%2Finternal%2FServiceDAO.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=eclipse#diff-Y29tbW9ucy9zcmMvbWFpbi9qYXZhL29yZy9lY2xpcHNlL2thcHVhL2NvbW1vbnMvc2VydmljZS9pbnRlcm5hbC9TZXJ2aWNlREFPLmphdmE=) | `0.00% <0.00%> (ø)` | |