eclipse / kapua

Eclipse Public License 2.0
222 stars 160 forks source link

:fix: service events remove durable subscriptions #4023

Closed riccardomodanese closed 3 months ago

riccardomodanese commented 4 months ago

Brief description of the PR. switch from durable to "normal" subscriptions for events. In this way, if a container is removed, we prevent message leak and event broker crash

Related Issue none

Description of the solution adopted See Brief description

Screenshots none

Any side note on the changes made none

codecov-commenter commented 4 months ago

Codecov Report

Attention: Patch coverage is 0% with 1 lines in your changes are missing coverage. Please review.

Project coverage is 16.67%. Comparing base (9506c48) to head (6d7c6d3).

Additional details and impacted files [![Impacted file tree graph](https://app.codecov.io/gh/eclipse/kapua/pull/4023/graphs/tree.svg?width=650&height=150&src=pr&token=1P4N4CApH8&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=eclipse)](https://app.codecov.io/gh/eclipse/kapua/pull/4023?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=eclipse) ```diff @@ Coverage Diff @@ ## develop #4023 +/- ## ========================================== Coverage 16.67% 16.67% Complexity 22 22 ========================================== Files 2009 2009 Lines 52223 52223 Branches 4437 4437 ========================================== Hits 8706 8706 Misses 43113 43113 Partials 404 404 ``` | [Files](https://app.codecov.io/gh/eclipse/kapua/pull/4023?dropdown=coverage&src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=eclipse) | Coverage Δ | | |---|---|---| | [...se/kapua/commons/event/jms/JMSServiceEventBus.java](https://app.codecov.io/gh/eclipse/kapua/pull/4023?src=pr&el=tree&filepath=commons%2Fsrc%2Fmain%2Fjava%2Forg%2Feclipse%2Fkapua%2Fcommons%2Fevent%2Fjms%2FJMSServiceEventBus.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=eclipse#diff-Y29tbW9ucy9zcmMvbWFpbi9qYXZhL29yZy9lY2xpcHNlL2thcHVhL2NvbW1vbnMvZXZlbnQvam1zL0pNU1NlcnZpY2VFdmVudEJ1cy5qYXZh) | `19.21% <0.00%> (ø)` | |