search

eclipse / kapua

Eclipse Public License 2.0
222 stars 160 forks source link

:bug: [Job] Fixed serialization of JobStepDefinition.stepProperties via REST API #4035

Closed Coduz closed 3 months ago

Coduz commented 3 months ago

This PR fixes the serialization of the JobStepDefinition via REST API.

This bug was introduced in https://github.com/eclipse/kapua/pull/3996/files#diff-192bd7bf065bc9a164960def70baba61fd6f6e4276d845a26cf82041f9bd9d5a

Related Issue This PR fixes a bug introduced with #3996

Description of the solution adopted Re-introduced removed setter of stepProperties

Screenshots None

Any side note on the changes made JobStepDefinitionRecord setters have been modified to be UnsupportedOperations since it is a read-only entity

codecov-commenter commented 3 months ago

Codecov Report

Attention: Patch coverage is 0% with 18 lines in your changes are missing coverage. Please review.

Project coverage is 16.71%. Comparing base (1e82551) to head (0e40c78).

Additional details and impacted files [![Impacted file tree graph](https://app.codecov.io/gh/eclipse/kapua/pull/4035/graphs/tree.svg?width=650&height=150&src=pr&token=1P4N4CApH8&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=eclipse)](https://app.codecov.io/gh/eclipse/kapua/pull/4035?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=eclipse) ```diff @@ Coverage Diff @@ ## develop #4035 +/- ## ========================================== Coverage 16.71% 16.71% Complexity 22 22 ========================================== Files 2009 2009 Lines 52229 52223 -6 Branches 4437 4437 ========================================== Hits 8728 8728 + Misses 43098 43092 -6 Partials 403 403 ``` | [Files](https://app.codecov.io/gh/eclipse/kapua/pull/4035?dropdown=coverage&src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=eclipse) | Coverage Δ | | |---|---|---| | [...service/job/step/definition/JobStepDefinition.java](https://app.codecov.io/gh/eclipse/kapua/pull/4035?src=pr&el=tree&filepath=service%2Fjob%2Fapi%2Fsrc%2Fmain%2Fjava%2Forg%2Feclipse%2Fkapua%2Fservice%2Fjob%2Fstep%2Fdefinition%2FJobStepDefinition.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=eclipse#diff-c2VydmljZS9qb2IvYXBpL3NyYy9tYWluL2phdmEvb3JnL2VjbGlwc2Uva2FwdWEvc2VydmljZS9qb2Ivc3RlcC9kZWZpbml0aW9uL0pvYlN0ZXBEZWZpbml0aW9uLmphdmE=) | `0.00% <ø> (ø)` | | | [...tep/definition/internal/JobStepDefinitionImpl.java](https://app.codecov.io/gh/eclipse/kapua/pull/4035?src=pr&el=tree&filepath=service%2Fjob%2Finternal%2Fsrc%2Fmain%2Fjava%2Forg%2Feclipse%2Fkapua%2Fservice%2Fjob%2Fstep%2Fdefinition%2Finternal%2FJobStepDefinitionImpl.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=eclipse#diff-c2VydmljZS9qb2IvaW50ZXJuYWwvc3JjL21haW4vamF2YS9vcmcvZWNsaXBzZS9rYXB1YS9zZXJ2aWNlL2pvYi9zdGVwL2RlZmluaXRpb24vaW50ZXJuYWwvSm9iU3RlcERlZmluaXRpb25JbXBsLmphdmE=) | `0.00% <0.00%> (ø)` | | | [...e/job/step/definition/JobStepDefinitionRecord.java](https://app.codecov.io/gh/eclipse/kapua/pull/4035?src=pr&el=tree&filepath=service%2Fjob%2Fapi%2Fsrc%2Fmain%2Fjava%2Forg%2Feclipse%2Fkapua%2Fservice%2Fjob%2Fstep%2Fdefinition%2FJobStepDefinitionRecord.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=eclipse#diff-c2VydmljZS9qb2IvYXBpL3NyYy9tYWluL2phdmEvb3JnL2VjbGlwc2Uva2FwdWEvc2VydmljZS9qb2Ivc3RlcC9kZWZpbml0aW9uL0pvYlN0ZXBEZWZpbml0aW9uUmVjb3JkLmphdmE=) | `0.00% <0.00%> (ø)` | |