search

eclipse / kapua

Eclipse Public License 2.0
222 stars 160 forks source link

Remove unnecessary localization logic #4038

Closed MDeLuise closed 3 months ago

MDeLuise commented 3 months ago

Description

This pull request addresses an XSS vulnerability by removing unnecessary localization logic from the console.jsp file. The original code dynamically set the locale based on request parameters, which could potentially be exploited by malicious users. Since our system does not support multiple languages, we replaced the dynamic logic with a static default locale of "en" to mitigate the XSS risk.

codecov-commenter commented 3 months ago

Codecov Report

All modified and coverable lines are covered by tests :white_check_mark:

Project coverage is 16.67%. Comparing base (c215cc9) to head (7412f03). Report is 4 commits behind head on develop.

Additional details and impacted files [![Impacted file tree graph](https://app.codecov.io/gh/eclipse/kapua/pull/4038/graphs/tree.svg?width=650&height=150&src=pr&token=1P4N4CApH8&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=eclipse)](https://app.codecov.io/gh/eclipse/kapua/pull/4038?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=eclipse) ```diff @@ Coverage Diff @@ ## develop #4038 +/- ## ============================================= - Coverage 16.71% 16.67% -0.04% Complexity 22 22 ============================================= Files 2009 2009 Lines 52223 52223 Branches 4437 4437 ============================================= - Hits 8728 8708 -20 - Misses 43092 43112 +20 Partials 403 403 ``` [see 2 files with indirect coverage changes](https://app.codecov.io/gh/eclipse/kapua/pull/4038/indirect-changes?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=eclipse)