search

eclipse / kapua

Eclipse Public License 2.0
222 stars 160 forks source link

πŸ› [REST API] Fixed returnNotNullEntity correctly handle null KapuaEntities #4041

Closed Coduz closed 3 months ago

Coduz commented 3 months ago

This PR fixes the implementation of AbstractKapuaResource.returnNotNullEntity(Object) to correctly produce a 404 HTTP error.

Related Issue None

Description of the solution adopted Fixed the thrown exception and added a new method to properly report a KapuaEntityNotFound exception when entity is null

Screenshots None

Any side note on the changes made None

codecov[bot] commented 3 months ago

Codecov Report

Attention: Patch coverage is 9.09091% with 30 lines in your changes are missing coverage. Please review.

Project coverage is 16.68%. Comparing base (618ab0f) to head (d858864).

Additional details and impacted files [![Impacted file tree graph](https://app.codecov.io/gh/eclipse/kapua/pull/4041/graphs/tree.svg?width=650&height=150&src=pr&token=1P4N4CApH8&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=eclipse)](https://app.codecov.io/gh/eclipse/kapua/pull/4041?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=eclipse) ```diff @@ Coverage Diff @@ ## develop #4041 +/- ## ============================================= + Coverage 16.67% 16.68% +0.01% Complexity 22 22 ============================================= Files 2009 2010 +1 Lines 52223 52189 -34 Branches 4437 4415 -22 ============================================= Hits 8706 8706 + Misses 43113 43079 -34 Partials 404 404 ``` | [Files](https://app.codecov.io/gh/eclipse/kapua/pull/4041?dropdown=coverage&src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=eclipse) | Coverage Ξ” | | |---|---|---| | [.../app/api/core/resources/AbstractKapuaResource.java](https://app.codecov.io/gh/eclipse/kapua/pull/4041?src=pr&el=tree&filepath=rest-api%2Fcore%2Fsrc%2Fmain%2Fjava%2Forg%2Feclipse%2Fkapua%2Fapp%2Fapi%2Fcore%2Fresources%2FAbstractKapuaResource.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=eclipse#diff-cmVzdC1hcGkvY29yZS9zcmMvbWFpbi9qYXZhL29yZy9lY2xpcHNlL2thcHVhL2FwcC9hcGkvY29yZS9yZXNvdXJjZXMvQWJzdHJhY3RLYXB1YVJlc291cmNlLmphdmE=) | `63.63% <75.00%> (-23.87%)` | :arrow_down: | | [...ua/app/api/resources/v1/resources/AccessInfos.java](https://app.codecov.io/gh/eclipse/kapua/pull/4041?src=pr&el=tree&filepath=rest-api%2Fresources%2Fsrc%2Fmain%2Fjava%2Forg%2Feclipse%2Fkapua%2Fapp%2Fapi%2Fresources%2Fv1%2Fresources%2FAccessInfos.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=eclipse#diff-cmVzdC1hcGkvcmVzb3VyY2VzL3NyYy9tYWluL2phdmEvb3JnL2VjbGlwc2Uva2FwdWEvYXBwL2FwaS9yZXNvdXJjZXMvdjEvcmVzb3VyY2VzL0FjY2Vzc0luZm9zLmphdmE=) | `0.00% <0.00%> (ΓΈ)` | | | [.../api/resources/v1/resources/AccessPermissions.java](https://app.codecov.io/gh/eclipse/kapua/pull/4041?src=pr&el=tree&filepath=rest-api%2Fresources%2Fsrc%2Fmain%2Fjava%2Forg%2Feclipse%2Fkapua%2Fapp%2Fapi%2Fresources%2Fv1%2Fresources%2FAccessPermissions.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=eclipse#diff-cmVzdC1hcGkvcmVzb3VyY2VzL3NyYy9tYWluL2phdmEvb3JnL2VjbGlwc2Uva2FwdWEvYXBwL2FwaS9yZXNvdXJjZXMvdjEvcmVzb3VyY2VzL0FjY2Vzc1Blcm1pc3Npb25zLmphdmE=) | `0.00% <0.00%> (ΓΈ)` | | | [...ua/app/api/resources/v1/resources/AccessRoles.java](https://app.codecov.io/gh/eclipse/kapua/pull/4041?src=pr&el=tree&filepath=rest-api%2Fresources%2Fsrc%2Fmain%2Fjava%2Forg%2Feclipse%2Fkapua%2Fapp%2Fapi%2Fresources%2Fv1%2Fresources%2FAccessRoles.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=eclipse#diff-cmVzdC1hcGkvcmVzb3VyY2VzL3NyYy9tYWluL2phdmEvb3JnL2VjbGlwc2Uva2FwdWEvYXBwL2FwaS9yZXNvdXJjZXMvdjEvcmVzb3VyY2VzL0FjY2Vzc1JvbGVzLmphdmE=) | `0.00% <0.00%> (ΓΈ)` | | | [.../kapua/app/api/resources/v1/resources/Account.java](https://app.codecov.io/gh/eclipse/kapua/pull/4041?src=pr&el=tree&filepath=rest-api%2Fresources%2Fsrc%2Fmain%2Fjava%2Forg%2Feclipse%2Fkapua%2Fapp%2Fapi%2Fresources%2Fv1%2Fresources%2FAccount.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=eclipse#diff-cmVzdC1hcGkvcmVzb3VyY2VzL3NyYy9tYWluL2phdmEvb3JnL2VjbGlwc2Uva2FwdWEvYXBwL2FwaS9yZXNvdXJjZXMvdjEvcmVzb3VyY2VzL0FjY291bnQuamF2YQ==) | `0.00% <0.00%> (ΓΈ)` | | | [...ua/app/api/resources/v1/resources/Credentials.java](https://app.codecov.io/gh/eclipse/kapua/pull/4041?src=pr&el=tree&filepath=rest-api%2Fresources%2Fsrc%2Fmain%2Fjava%2Forg%2Feclipse%2Fkapua%2Fapp%2Fapi%2Fresources%2Fv1%2Fresources%2FCredentials.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=eclipse#diff-cmVzdC1hcGkvcmVzb3VyY2VzL3NyYy9tYWluL2phdmEvb3JnL2VjbGlwc2Uva2FwdWEvYXBwL2FwaS9yZXNvdXJjZXMvdjEvcmVzb3VyY2VzL0NyZWRlbnRpYWxzLmphdmE=) | `0.00% <0.00%> (ΓΈ)` | | | [...esources/v1/resources/DeviceConnectionOptions.java](https://app.codecov.io/gh/eclipse/kapua/pull/4041?src=pr&el=tree&filepath=rest-api%2Fresources%2Fsrc%2Fmain%2Fjava%2Forg%2Feclipse%2Fkapua%2Fapp%2Fapi%2Fresources%2Fv1%2Fresources%2FDeviceConnectionOptions.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=eclipse#diff-cmVzdC1hcGkvcmVzb3VyY2VzL3NyYy9tYWluL2phdmEvb3JnL2VjbGlwc2Uva2FwdWEvYXBwL2FwaS9yZXNvdXJjZXMvdjEvcmVzb3VyY2VzL0RldmljZUNvbm5lY3Rpb25PcHRpb25zLmphdmE=) | `0.00% <0.00%> (ΓΈ)` | | | [.../api/resources/v1/resources/DeviceConnections.java](https://app.codecov.io/gh/eclipse/kapua/pull/4041?src=pr&el=tree&filepath=rest-api%2Fresources%2Fsrc%2Fmain%2Fjava%2Forg%2Feclipse%2Fkapua%2Fapp%2Fapi%2Fresources%2Fv1%2Fresources%2FDeviceConnections.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=eclipse#diff-cmVzdC1hcGkvcmVzb3VyY2VzL3NyYy9tYWluL2phdmEvb3JnL2VjbGlwc2Uva2FwdWEvYXBwL2FwaS9yZXNvdXJjZXMvdjEvcmVzb3VyY2VzL0RldmljZUNvbm5lY3Rpb25zLmphdmE=) | `0.00% <0.00%> (ΓΈ)` | | | [...a/app/api/resources/v1/resources/DeviceEvents.java](https://app.codecov.io/gh/eclipse/kapua/pull/4041?src=pr&el=tree&filepath=rest-api%2Fresources%2Fsrc%2Fmain%2Fjava%2Forg%2Feclipse%2Fkapua%2Fapp%2Fapi%2Fresources%2Fv1%2Fresources%2FDeviceEvents.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=eclipse#diff-cmVzdC1hcGkvcmVzb3VyY2VzL3NyYy9tYWluL2phdmEvb3JnL2VjbGlwc2Uva2FwdWEvYXBwL2FwaS9yZXNvdXJjZXMvdjEvcmVzb3VyY2VzL0RldmljZUV2ZW50cy5qYXZh) | `0.00% <0.00%> (ΓΈ)` | | | [...ources/DeviceManagementOperationNotifications.java](https://app.codecov.io/gh/eclipse/kapua/pull/4041?src=pr&el=tree&filepath=rest-api%2Fresources%2Fsrc%2Fmain%2Fjava%2Forg%2Feclipse%2Fkapua%2Fapp%2Fapi%2Fresources%2Fv1%2Fresources%2FDeviceManagementOperationNotifications.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=eclipse#diff-cmVzdC1hcGkvcmVzb3VyY2VzL3NyYy9tYWluL2phdmEvb3JnL2VjbGlwc2Uva2FwdWEvYXBwL2FwaS9yZXNvdXJjZXMvdjEvcmVzb3VyY2VzL0RldmljZU1hbmFnZW1lbnRPcGVyYXRpb25Ob3RpZmljYXRpb25zLmphdmE=) | `0.00% <0.00%> (ΓΈ)` | | | ... and [14 more](https://app.codecov.io/gh/eclipse/kapua/pull/4041?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=eclipse) | |