eclipse / kapua

Eclipse Public License 2.0
222 stars 160 forks source link

:bug: [Datastore] Refactored code related to TypeDescriptor Class #4045

Closed Agnul97 closed 2 months ago

Agnul97 commented 2 months ago

Brief description of the PR. I noticed that in the code there were still some references to the usage of Types ES feature that’s been deprecated time ago (https://www.elastic.co/guide/en/elasticsearch/reference/7.17/removal-of-types.html). Despite the fact that, time ago, the code was refactored to remove this feature there were still some reference to it, noticeably in the TypeDescriptor Class (a container of the pair index,type) that could be, practically, substituted by the sole index String. Here I removed the TypeDescriptor and all possible references to types linked to the datastore.

codecov[bot] commented 2 months ago

Codecov Report

Attention: Patch coverage is 0% with 67 lines in your changes are missing coverage. Please review.

Project coverage is 16.67%. Comparing base (20a640d) to head (9697947). Report is 8 commits behind head on develop.

Additional details and impacted files [![Impacted file tree graph](https://app.codecov.io/gh/eclipse/kapua/pull/4045/graphs/tree.svg?width=650&height=150&src=pr&token=1P4N4CApH8&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=eclipse)](https://app.codecov.io/gh/eclipse/kapua/pull/4045?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=eclipse) ```diff @@ Coverage Diff @@ ## develop #4045 +/- ## ========================================== Coverage 16.66% 16.67% Complexity 22 22 ========================================== Files 2009 2008 -1 Lines 52161 52134 -27 Branches 4409 4409 ========================================== Hits 8691 8691 + Misses 43068 43041 -27 Partials 402 402 ``` | [Files](https://app.codecov.io/gh/eclipse/kapua/pull/4045?dropdown=coverage&src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=eclipse) | Coverage Δ | | |---|---|---| | [...orable/model/query/predicate/IdsPredicateImpl.java](https://app.codecov.io/gh/eclipse/kapua/pull/4045?src=pr&el=tree&filepath=service%2Fcommons%2Fstorable%2Finternal%2Fsrc%2Fmain%2Fjava%2Forg%2Feclipse%2Fkapua%2Fservice%2Fstorable%2Fmodel%2Fquery%2Fpredicate%2FIdsPredicateImpl.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=eclipse#diff-c2VydmljZS9jb21tb25zL3N0b3JhYmxlL2ludGVybmFsL3NyYy9tYWluL2phdmEvb3JnL2VjbGlwc2Uva2FwdWEvc2VydmljZS9zdG9yYWJsZS9tb2RlbC9xdWVyeS9wcmVkaWNhdGUvSWRzUHJlZGljYXRlSW1wbC5qYXZh) | `0.00% <ø> (ø)` | | | [...e/internal/ChannelInfoElasticsearchRepository.java](https://app.codecov.io/gh/eclipse/kapua/pull/4045?src=pr&el=tree&filepath=service%2Fdatastore%2Finternal%2Fsrc%2Fmain%2Fjava%2Forg%2Feclipse%2Fkapua%2Fservice%2Fdatastore%2Finternal%2FChannelInfoElasticsearchRepository.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=eclipse#diff-c2VydmljZS9kYXRhc3RvcmUvaW50ZXJuYWwvc3JjL21haW4vamF2YS9vcmcvZWNsaXBzZS9rYXB1YS9zZXJ2aWNlL2RhdGFzdG9yZS9pbnRlcm5hbC9DaGFubmVsSW5mb0VsYXN0aWNzZWFyY2hSZXBvc2l0b3J5LmphdmE=) | `0.00% <ø> (ø)` | | | [...re/internal/ClientInfoElasticsearchRepository.java](https://app.codecov.io/gh/eclipse/kapua/pull/4045?src=pr&el=tree&filepath=service%2Fdatastore%2Finternal%2Fsrc%2Fmain%2Fjava%2Forg%2Feclipse%2Fkapua%2Fservice%2Fdatastore%2Finternal%2FClientInfoElasticsearchRepository.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=eclipse#diff-c2VydmljZS9kYXRhc3RvcmUvaW50ZXJuYWwvc3JjL21haW4vamF2YS9vcmcvZWNsaXBzZS9rYXB1YS9zZXJ2aWNlL2RhdGFzdG9yZS9pbnRlcm5hbC9DbGllbnRJbmZvRWxhc3RpY3NlYXJjaFJlcG9zaXRvcnkuamF2YQ==) | `0.00% <ø> (ø)` | | | [...e/datastore/internal/MetricInfoRepositoryImpl.java](https://app.codecov.io/gh/eclipse/kapua/pull/4045?src=pr&el=tree&filepath=service%2Fdatastore%2Finternal%2Fsrc%2Fmain%2Fjava%2Forg%2Feclipse%2Fkapua%2Fservice%2Fdatastore%2Finternal%2FMetricInfoRepositoryImpl.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=eclipse#diff-c2VydmljZS9kYXRhc3RvcmUvaW50ZXJuYWwvc3JjL21haW4vamF2YS9vcmcvZWNsaXBzZS9rYXB1YS9zZXJ2aWNlL2RhdGFzdG9yZS9pbnRlcm5hbC9NZXRyaWNJbmZvUmVwb3NpdG9yeUltcGwuamF2YQ==) | `0.00% <ø> (ø)` | | | [...vice/elasticsearch/client/model/InsertRequest.java](https://app.codecov.io/gh/eclipse/kapua/pull/4045?src=pr&el=tree&filepath=service%2Fcommons%2Felasticsearch%2Fclient-api%2Fsrc%2Fmain%2Fjava%2Forg%2Feclipse%2Fkapua%2Fservice%2Felasticsearch%2Fclient%2Fmodel%2FInsertRequest.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=eclipse#diff-c2VydmljZS9jb21tb25zL2VsYXN0aWNzZWFyY2gvY2xpZW50LWFwaS9zcmMvbWFpbi9qYXZhL29yZy9lY2xpcHNlL2thcHVhL3NlcnZpY2UvZWxhc3RpY3NlYXJjaC9jbGllbnQvbW9kZWwvSW5zZXJ0UmVxdWVzdC5qYXZh) | `0.00% <0.00%> (ø)` | | | [...ice/elasticsearch/client/model/InsertResponse.java](https://app.codecov.io/gh/eclipse/kapua/pull/4045?src=pr&el=tree&filepath=service%2Fcommons%2Felasticsearch%2Fclient-api%2Fsrc%2Fmain%2Fjava%2Forg%2Feclipse%2Fkapua%2Fservice%2Felasticsearch%2Fclient%2Fmodel%2FInsertResponse.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=eclipse#diff-c2VydmljZS9jb21tb25zL2VsYXN0aWNzZWFyY2gvY2xpZW50LWFwaS9zcmMvbWFpbi9qYXZhL29yZy9lY2xpcHNlL2thcHVhL3NlcnZpY2UvZWxhc3RpY3NlYXJjaC9jbGllbnQvbW9kZWwvSW5zZXJ0UmVzcG9uc2UuamF2YQ==) | `0.00% <0.00%> (ø)` | | | [...vice/elasticsearch/client/model/UpdateRequest.java](https://app.codecov.io/gh/eclipse/kapua/pull/4045?src=pr&el=tree&filepath=service%2Fcommons%2Felasticsearch%2Fclient-api%2Fsrc%2Fmain%2Fjava%2Forg%2Feclipse%2Fkapua%2Fservice%2Felasticsearch%2Fclient%2Fmodel%2FUpdateRequest.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=eclipse#diff-c2VydmljZS9jb21tb25zL2VsYXN0aWNzZWFyY2gvY2xpZW50LWFwaS9zcmMvbWFpbi9qYXZhL29yZy9lY2xpcHNlL2thcHVhL3NlcnZpY2UvZWxhc3RpY3NlYXJjaC9jbGllbnQvbW9kZWwvVXBkYXRlUmVxdWVzdC5qYXZh) | `0.00% <0.00%> (ø)` | | | [.../query/predicate/StorablePredicateFactoryImpl.java](https://app.codecov.io/gh/eclipse/kapua/pull/4045?src=pr&el=tree&filepath=service%2Fcommons%2Fstorable%2Finternal%2Fsrc%2Fmain%2Fjava%2Forg%2Feclipse%2Fkapua%2Fservice%2Fstorable%2Fmodel%2Fquery%2Fpredicate%2FStorablePredicateFactoryImpl.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=eclipse#diff-c2VydmljZS9jb21tb25zL3N0b3JhYmxlL2ludGVybmFsL3NyYy9tYWluL2phdmEvb3JnL2VjbGlwc2Uva2FwdWEvc2VydmljZS9zdG9yYWJsZS9tb2RlbC9xdWVyeS9wcmVkaWNhdGUvU3RvcmFibGVQcmVkaWNhdGVGYWN0b3J5SW1wbC5qYXZh) | `0.00% <0.00%> (ø)` | | | [...astore/internal/ChannelInfoRegistryFacadeImpl.java](https://app.codecov.io/gh/eclipse/kapua/pull/4045?src=pr&el=tree&filepath=service%2Fdatastore%2Finternal%2Fsrc%2Fmain%2Fjava%2Forg%2Feclipse%2Fkapua%2Fservice%2Fdatastore%2Finternal%2FChannelInfoRegistryFacadeImpl.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=eclipse#diff-c2VydmljZS9kYXRhc3RvcmUvaW50ZXJuYWwvc3JjL21haW4vamF2YS9vcmcvZWNsaXBzZS9rYXB1YS9zZXJ2aWNlL2RhdGFzdG9yZS9pbnRlcm5hbC9DaGFubmVsSW5mb1JlZ2lzdHJ5RmFjYWRlSW1wbC5qYXZh) | `0.00% <0.00%> (ø)` | | | [...tastore/internal/MetricInfoRegistryFacadeImpl.java](https://app.codecov.io/gh/eclipse/kapua/pull/4045?src=pr&el=tree&filepath=service%2Fdatastore%2Finternal%2Fsrc%2Fmain%2Fjava%2Forg%2Feclipse%2Fkapua%2Fservice%2Fdatastore%2Finternal%2FMetricInfoRegistryFacadeImpl.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=eclipse#diff-c2VydmljZS9kYXRhc3RvcmUvaW50ZXJuYWwvc3JjL21haW4vamF2YS9vcmcvZWNsaXBzZS9rYXB1YS9zZXJ2aWNlL2RhdGFzdG9yZS9pbnRlcm5hbC9NZXRyaWNJbmZvUmVnaXN0cnlGYWNhZGVJbXBsLmphdmE=) | `0.00% <0.00%> (ø)` | | | ... and [8 more](https://app.codecov.io/gh/eclipse/kapua/pull/4045?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=eclipse) | |