search

eclipse / kapua

Eclipse Public License 2.0
222 stars 160 forks source link

:fix: Credential Marshalling #4053

Closed dseurotech closed 2 months ago

dseurotech commented 2 months ago

xml annotations on CredentialImpl were overriding the ones on Credential, preventing XmlJavaTypeAdapters from being calle d

codecov[bot] commented 2 months ago

Codecov Report

All modified and coverable lines are covered by tests :white_check_mark:

Project coverage is 16.78%. Comparing base (839d04d) to head (2fbb818). Report is 4 commits behind head on develop.

Additional details and impacted files [![Impacted file tree graph](https://app.codecov.io/gh/eclipse/kapua/pull/4053/graphs/tree.svg?width=650&height=150&src=pr&token=1P4N4CApH8&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=eclipse)](https://app.codecov.io/gh/eclipse/kapua/pull/4053?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=eclipse) ```diff @@ Coverage Diff @@ ## develop #4053 +/- ## ============================================= - Coverage 16.78% 16.78% -0.01% Complexity 22 22 ============================================= Files 2006 2006 Lines 52087 52089 +2 Branches 4383 4384 +1 ============================================= Hits 8745 8745 - Misses 42947 42949 +2 Partials 395 395 ``` | [Files](https://app.codecov.io/gh/eclipse/kapua/pull/4053?dropdown=coverage&src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=eclipse) | Coverage Δ | | |---|---|---| | [...entication/credential/mfa/shiro/MfaOptionImpl.java](https://app.codecov.io/gh/eclipse/kapua/pull/4053?src=pr&el=tree&filepath=service%2Fsecurity%2Fshiro%2Fsrc%2Fmain%2Fjava%2Forg%2Feclipse%2Fkapua%2Fservice%2Fauthentication%2Fcredential%2Fmfa%2Fshiro%2FMfaOptionImpl.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=eclipse#diff-c2VydmljZS9zZWN1cml0eS9zaGlyby9zcmMvbWFpbi9qYXZhL29yZy9lY2xpcHNlL2thcHVhL3NlcnZpY2UvYXV0aGVudGljYXRpb24vY3JlZGVudGlhbC9tZmEvc2hpcm8vTWZhT3B0aW9uSW1wbC5qYXZh) | `100.00% <ø> (ø)` | | | [...tication/credential/mfa/shiro/ScratchCodeImpl.java](https://app.codecov.io/gh/eclipse/kapua/pull/4053?src=pr&el=tree&filepath=service%2Fsecurity%2Fshiro%2Fsrc%2Fmain%2Fjava%2Forg%2Feclipse%2Fkapua%2Fservice%2Fauthentication%2Fcredential%2Fmfa%2Fshiro%2FScratchCodeImpl.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=eclipse#diff-c2VydmljZS9zZWN1cml0eS9zaGlyby9zcmMvbWFpbi9qYXZhL29yZy9lY2xpcHNlL2thcHVhL3NlcnZpY2UvYXV0aGVudGljYXRpb24vY3JlZGVudGlhbC9tZmEvc2hpcm8vU2NyYXRjaENvZGVJbXBsLmphdmE=) | `100.00% <ø> (ø)` | | | [...uthentication/credential/shiro/CredentialImpl.java](https://app.codecov.io/gh/eclipse/kapua/pull/4053?src=pr&el=tree&filepath=service%2Fsecurity%2Fshiro%2Fsrc%2Fmain%2Fjava%2Forg%2Feclipse%2Fkapua%2Fservice%2Fauthentication%2Fcredential%2Fshiro%2FCredentialImpl.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=eclipse#diff-c2VydmljZS9zZWN1cml0eS9zaGlyby9zcmMvbWFpbi9qYXZhL29yZy9lY2xpcHNlL2thcHVhL3NlcnZpY2UvYXV0aGVudGljYXRpb24vY3JlZGVudGlhbC9zaGlyby9DcmVkZW50aWFsSW1wbC5qYXZh) | `100.00% <ø> (ø)` | | ... and [2 files with indirect coverage changes](https://app.codecov.io/gh/eclipse/kapua/pull/4053/indirect-changes?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=eclipse)