Closed MDeLuise closed 1 month ago
The ServiceConfigurations class methods (update, getComponent, updateComponent) currently return 204 or null when the following check is not true:
ServiceConfigurations
update
getComponent
updateComponent
204
null
if (KapuaConfigurableService.class.isAssignableFrom(configurableServiceClass)) { ... }
This behavior does not appropriately handle invalid user-provided values.
This pull request updates the methods in ServiceConfigurations to throw a KapuaIllegalArgument exception when appropiate.
KapuaIllegalArgument
Attention: Patch coverage is 0% with 19 lines in your changes missing coverage. Please review.
0%
19 lines
Project coverage is 16.81%. Comparing base (2349705) to head (c090c8a).
2349705
c090c8a
Description
The
ServiceConfigurations
class methods (update
,getComponent
,updateComponent
) currently return204
ornull
when the following check is not true:This behavior does not appropriately handle invalid user-provided values.
Solution
This pull request updates the methods in
ServiceConfigurations
to throw aKapuaIllegalArgument
exception when appropiate.