search

eclipse / kapua

Eclipse Public License 2.0
222 stars 160 forks source link

Fix add input validation to `KapuaConfigurableServiceBase` #4069

Closed MDeLuise closed 1 month ago

MDeLuise commented 1 month ago

Description

This pull request addresses an issue in the KapuaConfigurableServiceBase where input data was not being validated. The lack of validation could cause NullPointerExceptions (NPEs) for scopeId and configValues.

Changes Made

codecov[bot] commented 1 month ago

Codecov Report

Attention: Patch coverage is 0% with 5 lines in your changes missing coverage. Please review.

Project coverage is 16.80%. Comparing base (2349705) to head (62635ce). Report is 6 commits behind head on develop.

Additional details and impacted files [![Impacted file tree graph](https://app.codecov.io/gh/eclipse/kapua/pull/4069/graphs/tree.svg?width=650&height=150&src=pr&token=1P4N4CApH8&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=eclipse)](https://app.codecov.io/gh/eclipse/kapua/pull/4069?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=eclipse) ```diff @@ Coverage Diff @@ ## develop #4069 +/- ## ============================================= - Coverage 16.81% 16.80% -0.01% Complexity 22 22 ============================================= Files 2008 2008 Lines 52164 52182 +18 Branches 4398 4398 ============================================= Hits 8770 8770 - Misses 42998 43016 +18 Partials 396 396 ``` | [Files](https://app.codecov.io/gh/eclipse/kapua/pull/4069?dropdown=coverage&src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=eclipse) | Coverage Δ | | |---|---|---| | [...ns/configuration/KapuaConfigurableServiceBase.java](https://app.codecov.io/gh/eclipse/kapua/pull/4069?src=pr&el=tree&filepath=commons%2Fsrc%2Fmain%2Fjava%2Forg%2Feclipse%2Fkapua%2Fcommons%2Fconfiguration%2FKapuaConfigurableServiceBase.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=eclipse#diff-Y29tbW9ucy9zcmMvbWFpbi9qYXZhL29yZy9lY2xpcHNlL2thcHVhL2NvbW1vbnMvY29uZmlndXJhdGlvbi9LYXB1YUNvbmZpZ3VyYWJsZVNlcnZpY2VCYXNlLmphdmE=) | `31.81% <0.00%> (-9.36%)` | :arrow_down: | ... and [1 file with indirect coverage changes](https://app.codecov.io/gh/eclipse/kapua/pull/4069/indirect-changes?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=eclipse)