eclipse / kapua

Eclipse Public License 2.0
227 stars 160 forks source link

FIX - marshalling/unmarshalling Password[] and KuraPassword[] types #4106

Closed Agnul97 closed 2 months ago

Agnul97 commented 2 months ago

Brief description of the PR. I noticed that, when an XML/JSON representing a device configuration contains an array of Password or KuraPassword objects, something is wrong with the unmarshalling of it. This is also true for the opposite marshalling process

The problem lies in the *adapter classes we wrote to allow JAXB perform marshalling/unmarshalling processes

codecov[bot] commented 2 months ago

Codecov Report

Attention: Patch coverage is 0% with 2 lines in your changes missing coverage. Please review.

Project coverage is 16.80%. Comparing base (b0f10d9) to head (69f3242). Report is 12 commits behind head on develop.

Files with missing lines Patch % Lines
...onfiguration/metatype/PasswordPropertyAdapter.java 0.00% 1 Missing :warning:
...configuration/xml/KuraPasswordPropertyAdapter.java 0.00% 1 Missing :warning:
Additional details and impacted files [![Impacted file tree graph](https://app.codecov.io/gh/eclipse/kapua/pull/4106/graphs/tree.svg?width=650&height=150&src=pr&token=1P4N4CApH8&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=eclipse)](https://app.codecov.io/gh/eclipse/kapua/pull/4106?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=eclipse) ```diff @@ Coverage Diff @@ ## develop #4106 +/- ## ============================================= + Coverage 16.79% 16.80% +0.01% Complexity 22 22 ============================================= Files 2019 2019 Lines 52410 52410 Branches 4416 4417 +1 ============================================= + Hits 8800 8810 +10 + Misses 43210 43202 -8 + Partials 400 398 -2 ``` | [Files with missing lines](https://app.codecov.io/gh/eclipse/kapua/pull/4106?dropdown=coverage&src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=eclipse) | Coverage Δ | | |---|---|---| | [...onfiguration/metatype/PasswordPropertyAdapter.java](https://app.codecov.io/gh/eclipse/kapua/pull/4106?src=pr&el=tree&filepath=commons%2Fsrc%2Fmain%2Fjava%2Forg%2Feclipse%2Fkapua%2Fcommons%2Fconfiguration%2Fmetatype%2FPasswordPropertyAdapter.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=eclipse#diff-Y29tbW9ucy9zcmMvbWFpbi9qYXZhL29yZy9lY2xpcHNlL2thcHVhL2NvbW1vbnMvY29uZmlndXJhdGlvbi9tZXRhdHlwZS9QYXNzd29yZFByb3BlcnR5QWRhcHRlci5qYXZh) | `14.28% <0.00%> (+0.64%)` | :arrow_up: | | [...configuration/xml/KuraPasswordPropertyAdapter.java](https://app.codecov.io/gh/eclipse/kapua/pull/4106?src=pr&el=tree&filepath=service%2Fdevice%2Fcall%2Fkura%2Fsrc%2Fmain%2Fjava%2Forg%2Feclipse%2Fkapua%2Fservice%2Fdevice%2Fcall%2Fkura%2Fmodel%2Fconfiguration%2Fxml%2FKuraPasswordPropertyAdapter.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=eclipse#diff-c2VydmljZS9kZXZpY2UvY2FsbC9rdXJhL3NyYy9tYWluL2phdmEvb3JnL2VjbGlwc2Uva2FwdWEvc2VydmljZS9kZXZpY2UvY2FsbC9rdXJhL21vZGVsL2NvbmZpZ3VyYXRpb24veG1sL0t1cmFQYXNzd29yZFByb3BlcnR5QWRhcHRlci5qYXZh) | `14.28% <0.00%> (+0.64%)` | :arrow_up: | ... and [3 files with indirect coverage changes](https://app.codecov.io/gh/eclipse/kapua/pull/4106/indirect-changes?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=eclipse)