eclipse / kapua

Eclipse Public License 2.0
227 stars 160 forks source link

✨ [MFA] Added new 'hasTrustMe' attribute #4115

Closed Coduz closed 1 month ago

Coduz commented 1 month ago

This PR adds hasTrustMe flag to MfaOption entity. This will tell whether the MfaOption has a trustKey, since we are not returning the trustKey after creation.

Related Issue None

Description of the solution adopted Added new attribute and related documentation

Screenshots None

Any side note on the changes made Updated Javadocs

codecov[bot] commented 1 month ago

Codecov Report

Attention: Patch coverage is 21.42857% with 11 lines in your changes missing coverage. Please review.

Project coverage is 16.81%. Comparing base (c92b620) to head (f537eda). Report is 5 commits behind head on develop.

Files with missing lines Patch % Lines
...entication/credential/mfa/shiro/MfaOptionImpl.java 23.07% 10 Missing :warning:
...ntication/credential/mfa/MfaOptionXmlRegistry.java 0.00% 1 Missing :warning:
Additional details and impacted files [![Impacted file tree graph](https://app.codecov.io/gh/eclipse/kapua/pull/4115/graphs/tree.svg?width=650&height=150&src=pr&token=1P4N4CApH8&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=eclipse)](https://app.codecov.io/gh/eclipse/kapua/pull/4115?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=eclipse) ```diff @@ Coverage Diff @@ ## develop #4115 +/- ## ========================================== Coverage 16.81% 16.81% Complexity 22 22 ========================================== Files 2019 2019 Lines 52418 52431 +13 Branches 4418 4421 +3 ========================================== + Hits 8813 8816 +3 - Misses 43208 43218 +10 Partials 397 397 ``` | [Files with missing lines](https://app.codecov.io/gh/eclipse/kapua/pull/4115?dropdown=coverage&src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=eclipse) | Coverage Δ | | |---|---|---| | [...rvice/authentication/credential/mfa/MfaOption.java](https://app.codecov.io/gh/eclipse/kapua/pull/4115?src=pr&el=tree&filepath=service%2Fsecurity%2Fauthentication%2Fapi%2Fsrc%2Fmain%2Fjava%2Forg%2Feclipse%2Fkapua%2Fservice%2Fauthentication%2Fcredential%2Fmfa%2FMfaOption.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=eclipse#diff-c2VydmljZS9zZWN1cml0eS9hdXRoZW50aWNhdGlvbi9hcGkvc3JjL21haW4vamF2YS9vcmcvZWNsaXBzZS9rYXB1YS9zZXJ2aWNlL2F1dGhlbnRpY2F0aW9uL2NyZWRlbnRpYWwvbWZhL01mYU9wdGlvbi5qYXZh) | `0.00% <ø> (ø)` | | | [...entication/credential/mfa/MfaOptionAttributes.java](https://app.codecov.io/gh/eclipse/kapua/pull/4115?src=pr&el=tree&filepath=service%2Fsecurity%2Fauthentication%2Fapi%2Fsrc%2Fmain%2Fjava%2Forg%2Feclipse%2Fkapua%2Fservice%2Fauthentication%2Fcredential%2Fmfa%2FMfaOptionAttributes.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=eclipse#diff-c2VydmljZS9zZWN1cml0eS9hdXRoZW50aWNhdGlvbi9hcGkvc3JjL21haW4vamF2YS9vcmcvZWNsaXBzZS9rYXB1YS9zZXJ2aWNlL2F1dGhlbnRpY2F0aW9uL2NyZWRlbnRpYWwvbWZhL01mYU9wdGlvbkF0dHJpYnV0ZXMuamF2YQ==) | `0.00% <ø> (ø)` | | | [...ice/authentication/credential/mfa/ScratchCode.java](https://app.codecov.io/gh/eclipse/kapua/pull/4115?src=pr&el=tree&filepath=service%2Fsecurity%2Fauthentication%2Fapi%2Fsrc%2Fmain%2Fjava%2Forg%2Feclipse%2Fkapua%2Fservice%2Fauthentication%2Fcredential%2Fmfa%2FScratchCode.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=eclipse#diff-c2VydmljZS9zZWN1cml0eS9hdXRoZW50aWNhdGlvbi9hcGkvc3JjL21haW4vamF2YS9vcmcvZWNsaXBzZS9rYXB1YS9zZXJ2aWNlL2F1dGhlbnRpY2F0aW9uL2NyZWRlbnRpYWwvbWZhL1NjcmF0Y2hDb2RlLmphdmE=) | `0.00% <ø> (ø)` | | | [...ication/credential/mfa/ScratchCodeXmlRegistry.java](https://app.codecov.io/gh/eclipse/kapua/pull/4115?src=pr&el=tree&filepath=service%2Fsecurity%2Fauthentication%2Fapi%2Fsrc%2Fmain%2Fjava%2Forg%2Feclipse%2Fkapua%2Fservice%2Fauthentication%2Fcredential%2Fmfa%2FScratchCodeXmlRegistry.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=eclipse#diff-c2VydmljZS9zZWN1cml0eS9hdXRoZW50aWNhdGlvbi9hcGkvc3JjL21haW4vamF2YS9vcmcvZWNsaXBzZS9rYXB1YS9zZXJ2aWNlL2F1dGhlbnRpY2F0aW9uL2NyZWRlbnRpYWwvbWZhL1NjcmF0Y2hDb2RlWG1sUmVnaXN0cnkuamF2YQ==) | `50.00% <ø> (ø)` | | | [...ntication/credential/mfa/MfaOptionXmlRegistry.java](https://app.codecov.io/gh/eclipse/kapua/pull/4115?src=pr&el=tree&filepath=service%2Fsecurity%2Fauthentication%2Fapi%2Fsrc%2Fmain%2Fjava%2Forg%2Feclipse%2Fkapua%2Fservice%2Fauthentication%2Fcredential%2Fmfa%2FMfaOptionXmlRegistry.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=eclipse#diff-c2VydmljZS9zZWN1cml0eS9hdXRoZW50aWNhdGlvbi9hcGkvc3JjL21haW4vamF2YS9vcmcvZWNsaXBzZS9rYXB1YS9zZXJ2aWNlL2F1dGhlbnRpY2F0aW9uL2NyZWRlbnRpYWwvbWZhL01mYU9wdGlvblhtbFJlZ2lzdHJ5LmphdmE=) | `33.33% <0.00%> (ø)` | | | [...entication/credential/mfa/shiro/MfaOptionImpl.java](https://app.codecov.io/gh/eclipse/kapua/pull/4115?src=pr&el=tree&filepath=service%2Fsecurity%2Fshiro%2Fsrc%2Fmain%2Fjava%2Forg%2Feclipse%2Fkapua%2Fservice%2Fauthentication%2Fcredential%2Fmfa%2Fshiro%2FMfaOptionImpl.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=eclipse#diff-c2VydmljZS9zZWN1cml0eS9zaGlyby9zcmMvbWFpbi9qYXZhL29yZy9lY2xpcHNlL2thcHVhL3NlcnZpY2UvYXV0aGVudGljYXRpb24vY3JlZGVudGlhbC9tZmEvc2hpcm8vTWZhT3B0aW9uSW1wbC5qYXZh) | `77.77% <23.07%> (-22.23%)` | :arrow_down: |