search

eclipse / kiso-testing

https://kiso-testing.readthedocs.io/
Other
36 stars 41 forks source link

fix: stop rx task call before start rx task is called #476

Closed yannpoupon closed 1 month ago

yannpoupon commented 1 month ago

Fix a rare case where the join() function could be called before the thread is started.

sebastianpfischer commented 1 month ago

A rebase is first needed to compare with the updated ci checks

codecov[bot] commented 1 month ago

Codecov Report

All modified and coverable lines are covered by tests :white_check_mark:

Project coverage is 97.04%. Comparing base (f1e6657) to head (59f9aac). Report is 11 commits behind head on master.

Additional details and impacted files ```diff @@ Coverage Diff @@ ## master #476 +/- ## ========================================== - Coverage 98.14% 97.04% -1.11% ========================================== Files 84 84 Lines 6750 6763 +13 ========================================== - Hits 6625 6563 -62 - Misses 125 200 +75 ```

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

sebastianpfischer commented 1 month ago

@yannpoupon , looks fine for me. Is there a way to verify it?

yannpoupon commented 1 month ago

@yannpoupon , looks fine for me. Is there a way to verify it?

It has been tested by the person that reported the bug, on a stability test with 2000 runs and the error was never raised.

sebastianpfischer commented 1 month ago

I guess I can live with that ^^