search

eclipse / kuksa.val.feeders

kuksa.val.feeders
Apache License 2.0
8 stars 22 forks source link

Fix kuksa-client dependencies #120

Closed erikbosch closed 1 year ago

erikbosch commented 1 year ago

It seems we use cache when calling pypi, but we want a fresh build

sophokles73 commented 1 year ago

Just for my understanding: you now expect the building of the container to fail, because it will not be able to resolve the (alpha) 4.0.x version, right?

erikbosch commented 1 year ago

@sophokles73 - When updating the kuksa-client dependencies earlier I made a mistake, I thought > 0.3 would not match 0.3.1 but that seems to be the case. Not a problem if you use --pre, especially not in CI/Docker builds where you start from scratch. So this PR now updates minimum version to latest kuksa-client pre-release, and adds --prefor csv provider.

Separately I tried to improve https://github.com/eclipse/kuksa.val.feeders/wiki/Release-Process. When we do a release we need to remove --pre and change version, when releasing the feeders possibly even choose a fixed version to make it possible to rebuild using exactly the same version.

erikbosch commented 1 year ago

@lukasmittag @sophokles73 - please check if you think this one is OK for merge now

sophokles73 commented 1 year ago

I have started the ephemeral image and did not run into the original problem anymore. LGTM