search

eclipse / kuksa.val.feeders

kuksa.val.feeders
Apache License 2.0
8 stars 22 forks source link

Warn on DBC signal name usage across multiple messages #132

Closed sophokles73 closed 5 months ago

sophokles73 commented 10 months ago

During startup, the DBC Feeder reads in CAN message definitions from arbitrary database files. When using the same signal name in different message definitions, care needs to be taken that the semantics of the signal are the same across all messages.

The DBC Feeder has been changed to detect such cases and issue a corresponding warning if the signal is being mapped to a VSS datapoint.

This addresses #122

erikbosch commented 10 months ago

Conflicts now as well

erikbosch commented 6 months ago

We are migrating CAN Provider (dbcfeeder) to a new repo. Discussion may continue in this PR, but there is no point in updating this PR, if so rather create a new PR in the new repository.

erikbosch commented 5 months ago

@sophokles73 - I think it would be bad if we would loose this PR. Do you intend to work something on it within the next months, or should I try to do some work to make it up-to-date for the new repo?

sophokles73 commented 5 months ago

@erikbosch let me see if I find the time to migrate the PR to the new repo ...

sophokles73 commented 5 months ago

@erikbosch I have rebased this PR locally. Once #122 has been migrated to the new repo, I will recreate the PR in the new repo ...

erikbosch commented 5 months ago

I created a new issue in the new repo, see https://github.com/eclipse-kuksa/kuksa-can-provider/issues/8