search

eclipse / kuksa.val.feeders

kuksa.val.feeders
Apache License 2.0
8 stars 22 forks source link

Improve registration handling #60

Closed erikbosch closed 1 year ago

erikbosch commented 1 year ago

As databroker does not support registration let us instead just check that the signal actually actually is registered and exit if not all are registered.

No retry-mechanism, if somethings fails you need to restart feeder.

This is the output with the PR if trying to run against a Databroker with no signals defined.

2023-02-17 13:32:51,301 INFO dbcfeeder: Connectivity changed to: ChannelConnectivity.READY
2023-02-17 13:32:51,301 INFO dbcfeeder: Connected to data broker
2023-02-17 13:32:52,504 INFO dbcfeeder: Check that datapoints are registered
2023-02-17 13:32:52,509 ERROR dbcfeederlib.databroker: Signal Vehicle.Body.Lights.IsBackupOn is not registered
2023-02-17 13:32:52,515 ERROR dbcfeederlib.databroker: Signal Vehicle.Body.Lights.IsBrakeOn is not registered
2023-02-17 13:32:52,520 ERROR dbcfeederlib.databroker: Signal Vehicle.Body.Lights.IsRearFogOn is not registered
2023-02-17 13:32:52,526 ERROR dbcfeederlib.databroker: Signal Vehicle.Body.Lights.IsLeftIndicatorOn is not registered
2023-02-17 13:32:52,530 ERROR dbcfeederlib.databroker: Signal Vehicle.Body.Lights.IsRightIndicatorOn is not registered
2023-02-17 13:32:52,533 ERROR dbcfeederlib.databroker: Signal Vehicle.Body.Mirrors.Left.IsHeatingOn is not registered
2023-02-17 13:32:52,537 ERROR dbcfeederlib.databroker: Signal Vehicle.Body.Mirrors.Right.IsHeatingOn is not registered
2023-02-17 13:32:52,540 ERROR dbcfeederlib.databroker: Signal Vehicle.Body.Mirrors.Left.Pan is not registered
2023-02-17 13:32:52,541 ERROR dbcfeederlib.databroker: Signal Vehicle.Body.Mirrors.Left.Tilt is not registered
2023-02-17 13:32:52,543 ERROR dbcfeederlib.databroker: Signal Vehicle.Body.Mirrors.Right.Pan is not registered
2023-02-17 13:32:52,545 ERROR dbcfeederlib.databroker: Signal Vehicle.Body.Mirrors.Right.Tilt is not registered
2023-02-17 13:32:52,548 ERROR dbcfeederlib.databroker: Signal Vehicle.Body.Trunk.Rear.IsOpen is not registered
2023-02-17 13:32:52,552 ERROR dbcfeederlib.databroker: Signal Vehicle.Body.Windshield.Front.WasherFluid.IsLevelLow is not registered
2023-02-17 13:32:52,554 ERROR dbcfeederlib.databroker: Signal Vehicle.Cabin.Door.Row1.Left.IsOpen is not registered
2023-02-17 13:32:52,556 ERROR dbcfeederlib.databroker: Signal Vehicle.Cabin.Seat.Row1.Pos1.IsBelted is not registered
2023-02-17 13:32:52,558 ERROR dbcfeederlib.databroker: Signal Vehicle.Chassis.Axle.Row1.Wheel.Left.Brake.IsFluidLevelLow is not registered
2023-02-17 13:32:52,559 ERROR dbcfeederlib.databroker: Signal Vehicle.Chassis.Axle.Row1.Wheel.Right.Brake.IsFluidLevelLow is not registered
2023-02-17 13:32:52,561 ERROR dbcfeederlib.databroker: Signal Vehicle.Chassis.Axle.Row2.Wheel.Left.Brake.IsFluidLevelLow is not registered
2023-02-17 13:32:52,563 ERROR dbcfeederlib.databroker: Signal Vehicle.Chassis.Axle.Row2.Wheel.Right.Brake.IsFluidLevelLow is not registered
2023-02-17 13:32:52,566 ERROR dbcfeederlib.databroker: Signal Vehicle.Chassis.SteeringWheel.Angle is not registered
2023-02-17 13:32:52,572 ERROR dbcfeederlib.databroker: Signal Vehicle.OBD.AmbientAirTemperature is not registered
2023-02-17 13:32:52,574 ERROR dbcfeederlib.databroker: Signal Vehicle.OBD.ControlModuleVoltage is not registered
2023-02-17 13:32:52,575 ERROR dbcfeederlib.databroker: Signal Vehicle.OBD.EngineLoad is not registered
2023-02-17 13:32:52,577 ERROR dbcfeederlib.databroker: Signal Vehicle.OBD.Speed is not registered
2023-02-17 13:32:52,579 ERROR dbcfeederlib.databroker: Signal Vehicle.Speed is not registered
2023-02-17 13:32:52,581 ERROR dbcfeederlib.databroker: Signal Vehicle.Powertrain.ElectricMotor.Temperature is not registered
2023-02-17 13:32:52,583 ERROR dbcfeederlib.databroker: Signal Vehicle.Powertrain.ElectricMotor.Torque is not registered
2023-02-17 13:32:52,585 ERROR dbcfeederlib.databroker: Signal Vehicle.Powertrain.TractionBattery.Charging.IsCharging is not registered
2023-02-17 13:32:52,587 ERROR dbcfeederlib.databroker: Signal Vehicle.Powertrain.Transmission.CurrentGear is not registered
2023-02-17 13:32:52,589 ERROR dbcfeederlib.databroker: Signal Vehicle.Powertrain.Transmission.IsParkLockEngaged is not registered
2023-02-17 13:32:52,591 ERROR dbcfeederlib.databroker: Signal Vehicle.Trailer.IsConnected is not registered
2023-02-17 13:32:52,591 ERROR dbcfeeder: Failed to register datapoints, exiting!
2023-02-17 13:32:52,591 INFO dbcfeeder: Shutting down...
2023-02-17 13:32:52,592 INFO dbcfeederlib.canplayer: Stopped Tx thread
2023-02-17 13:32:53,590 INFO dbcfeederlib.dbcreader: Stopped Rx thread
SebastianSchildt commented 1 year ago

I think this error

2023-02-17 13:32:52,591 ERROR dbcfeeder: Failed to register datapoints, exiting!

should be rephrased, indicating, that not all datapoints are registered/known by databroker