eclipse / kuksa.val.feeders

kuksa.val.feeders
Apache License 2.0
8 stars 22 forks source link

Update to VSS 3.1.1 #63

Closed erikbosch closed 1 year ago

erikbosch commented 1 year ago

In theory this would have been a very small PR but it grew a bit bigger:

SebastianSchildt commented 1 year ago

I am wondering, whether it would be better to provide a 3.1.1 AND a 3.0 mapping file. Currently the mapping is not compatible with the the released/3.0 databroker

2023-03-02 16:53:03,447 ERROR dbcfeederlib.databroker: Signal Vehicle.Body.Lights.Backup.IsOn is not registered
2023-03-02 16:53:03,452 ERROR dbcfeederlib.databroker: Signal Vehicle.Body.Lights.Brake.IsActive is not registered
2023-03-02 16:53:03,460 ERROR dbcfeederlib.databroker: Signal Vehicle.Body.Lights.Fog.Rear.IsOn is not registered
2023-03-02 16:53:03,464 ERROR dbcfeederlib.databroker: Signal Vehicle.Body.Lights.DirectionIndicator.Left.IsSignaling is not registered
2023-03-02 16:53:03,467 ERROR dbcfeederlib.databroker: Signal Vehicle.Body.Lights.DirectionIndicator.Right.IsSignaling is not registered

I guess we could just copy the file and remove the Light signals. At least then, in case of problems, we can tell people "use the 3.0 mapping", instead of "go to some older version of DBC feeder" (that may have other problems)