Closed erikbosch closed 1 year ago
@SebastianSchildt - Due to the newly introduced changes in kuksa-client we should reserve some time to do regressions tests on all existing KUKSA.val feeders/providers as well as services before we do the next official release. Apart from that, if last build on this one pass it should be ready for merge
@erikbosch Agreed on the testing.
How about this one now, your comment says it should be fine for merge, but state is still "Change requested"
@erikbosch Agreed on the testing.
How about this one now, your comment says it should be fine for merge, but state is still "Change requested"
I will review.
@erikbosch Agreed on the testing.
How about this one now, your comment says it should be fine for merge, but state is still "Change requested"
That is the Github way of working - if someone has requested changes the best way for the "changes requested" to disappear is to that the one who reviewed and requested changes review again and approve. I believe that it also is possible to delete someones review, but do not really know who has permission to do that
Also refactored to use linter and logging. Parts of this could eventually later be moved to a common place for all Python feeders
Test performed: