search

eclipse / kuksa.val.feeders

kuksa.val.feeders
Apache License 2.0
8 stars 22 forks source link

[dbc2val] Pin pyinstaller version used for container image build #87

Closed sophokles73 closed 1 year ago

sophokles73 commented 1 year ago

This is for #86

The pyinstaller version has been pinned to 5.9.0 to prevent usage of the recently released 5.10.0 version which contains an internal API change that causes staticx to break.

See https://github.com/JonathonReinhart/staticx/issues/235

Also changed the Dockerfile to install the standard patchelf OS package instead of using pip install because this is the approach recommended by the staticx installation guide.

erikbosch commented 1 year ago

We need to improve why we do things. The patchelf pinning was recently added by https://github.com/eclipse/kuksa.val.feeders/pull/50 but we do not really provide more information on why it was needed. @lukasmittag - can you check if the reason for a pinned version is still relevant.

@sophokles73 - @SebastianSchildt has another solution addressing the same problem in https://github.com/eclipse/kuksa.val.feeders/pull/83. Could you possibly check if that solution fits your needs as well? I guess that either that one or this one shall be merged.

sophokles73 commented 1 year ago

@SebastianSchildt has another solution addressing the same problem in https://github.com/eclipse/kuksa.val.feeders/pull/83. Could you possibly check if that solution fits your needs as well? I guess that either that one or this one shall be merged.

I had indeed seen it and its approach should definitely work. This PR was intended as a quick fix until #83 is being merged ...

sophokles73 commented 1 year ago

fixed via https://github.com/eclipse/kuksa.val.feeders/commit/2feefd14701811020ccb59ec2efe9a1a6ccd0b31