Refactoring of oci build

eclipse / kuksa.val.services

Repository for Vehicle Service Related implementations for Eclipse SDV

Apache License 2.0

15 stars 18 forks source link

Refactoring of oci build #105

Closed erikbosch closed 8 months ago

erikbosch commented 8 months ago

This PR refactor the oci build and align it how it handled in KUKSA Databroker

Functional changes:

Trigger also on PRs
Check if secrets are available, only try to publish to ghcr.io if secrets are supposed to be present
Uses hardcoded push target, previously repo name was used as variable
Fixes problem in Dockerfile causing previous builds to fail
Remove "prerelease" script, we can instead have a prerelease branch if needed and run it from there

The question is - do we see any problems using same setup as kuksa.val?

SebastianSchildt commented 8 months ago

I very much like the fact to build it in a smiliar style as in databroker CI. That is easier to maintain/understand than having several ways

But in this case @erikbosch this devl container image is quite fat, so does the ttl.sh upload even work? Or aren't we still bitten by the "buildx can't do chunked uploads" bug?

erikbosch commented 8 months ago

I very much like the fact to build it in a smiliar style as in databroker CI. That is easier to maintain/understand than having several ways

But in this case @erikbosch this devl container image is quite fat, so does the ttl.sh upload even work? Or aren't we still bitten by the "buildx can't do chunked uploads" bug?

It seems to have worked for this PR, now the container has likely expired but i can try again

erikbosch commented 8 months ago

I tested that ttl upload works.

https://github.com/eclipse/kuksa.val.services/actions/runs/6769240878

erik@debian4:~/kuksa.val.services/.github/actions$ docker run --rm -it --net=host ttl.sh/kuksa.val.services/oci_kuksa-val-services-ci-ff6be40a33d2f6d3a56d89ac56b4a7d286749d1d
root@debian4:/workspace# pwd
/workspace
root@debian4:/workspace# exit
exit