search

eclipse / kuksa.val.services

Repository for Vehicle Service Related implementations for Eclipse SDV
Apache License 2.0
15 stars 18 forks source link

Add a GUI to showcase the abilities of the HVAC service #41

Closed lukasmittag closed 6 months ago

lukasmittag commented 1 year ago

GUI is implemented through the DearPyGUI (licenses need to be added before merging). It mocks a sensor and an application in the car or on a phone. Very lightweight and nothing too special.

SebastianSchildt commented 1 year ago

Like the idea. Things I noticed: Should probably add all needed dependencies to Pipfile, missing was

grpcio
dearpygui
protobuf

dearpygui itself should not be a problem as new dependency (MIT),

When looking into the API migration we might also want to think about, whether we want to port/rewrite this demo in "Pure VSS" style, as this should be quite easy in this example.

Found a little crash when putting the "Ratio to poll sensor" to 0


    if (count % sensor_ratio) == 0:
ZeroDivisionError: integer division or modulo by zero
``
romainletendart commented 1 year ago

I'll let Sebastian review your recent changes but then I think you can squash your commits. Currently your commits kind of belong together as you're mostly fixing issues on the first commit. We can benefit from the fact that commits are not yet merged into main branch to have more atomic commits.

lukasmittag commented 6 months ago

Since there is the android companion app closing this