eclipse / kuksa.val.services

Repository for Vehicle Service Related implementations for Eclipse SDV
Apache License 2.0
15 stars 18 forks source link

Subscribe to actuator with kuksa.val.v1 #47

Closed argerus closed 1 year ago

SebastianSchildt commented 1 year ago

On Seat service side, the Readme seems completely outdated: https://github.com/boschglobal/kuksa.val.services/blob/feature/kuksa_val_v1_subscribe_actuator/seat_service/README.md

folder "tools" does not exist (it says building docker there), building in seat_service dir does not work with vanilla docker (as the files require buildx), then just using buildx, does not work because artifacts missing, then there is the docker-build.sh that seems to be talking care of this, but none of the requriements it needs on host are documented (cmaka conan),

Can you at least remove the "wrong" information in Readme, and say how it is supposed to be built (i.e. if I am on the right track even saying "use the build docker script and figure errors out along the way" is better than currently.

Also a small doubt, can it even work (still fighting with dependencies...) , because as last exit the script gives me ERROR: oci for multi-node builds currently not supported

SebastianSchildt commented 1 year ago

.build_release.sh fails with

[ 90%] Building CXX object src/bin/seat_service/CMakeFiles/seat_service.dir/seat_data_feeder.cc.o
[ 93%] Building CXX object src/bin/seat_service/CMakeFiles/seat_service.dir/seat_position_subscriber.cc.o
[ 95%] Building CXX object src/bin/seat_service/CMakeFiles/seat_service.dir/main.cc.o
In file included from /home/sebastian/kuksa.val.services/seat_service/src/bin/seat_service/seat_position_subscriber.cc:18:
/home/sebastian/kuksa.val.services/seat_service/src/bin/seat_service/seat_position_subscriber.h:61:17: error: field ‘seat_pos_name_’ has incomplete type ‘std::string’ {aka ‘std::__cxx11::basic_string<char>’}
   61 |     std::string seat_pos_name_;
      |                 ^~~~~~~~~~~~~~
In file included from /usr/include/c++/11/iosfwd:39,
                 from /usr/include/c++/11/bits/shared_ptr.h:52,
                 from /usr/include/c++/11/memory:77,
                 from /home/sebastian/kuksa.val.services/seat_service/src/bin/seat_service/seat_position_subscriber.h:26,
                 from /home/sebastian/kuksa.val.services/seat_service/src/bin/seat_service/seat_position_subscriber.cc:18:
/usr/include/c++/11/bits/stringfwd.h:74:11: note: declaration of ‘std::string’ {aka ‘class std::__cxx11::basic_string<char>’}
   74 |     class basic_string;
      |           ^~~~~~~~~~~~
[ 95%] Built target seat_svc_client
gmake[2]: *** [src/bin/seat_service/CMakeFiles/seat_service.dir/build.make:90: src/bin/seat_service/CMakeFiles/seat_service.dir/seat_position_subscriber.cc.o] Error 1
gmake[2]: *** Waiting for unfinished jobs....
[ 97%] Linking CXX executable broker_feeder
SebastianSchildt commented 1 year ago

Regarding doc issues created a new issue #48

SebastianSchildt commented 1 year ago

Figured out how the "tools" base docker is supposed to be build, and updated docs

int0x27 commented 1 year ago

CI totally fails, I would at least expect the enabled seat service related CI to run.

@argerus @int0x27 Any idea what the issue is? Looks like a another conan explosion?

gtest recipe problem seems temporary issue, can you try re-running the CI again?