eclipse / kuksa.val.services

Repository for Vehicle Service Related implementations for Eclipse SDV
Apache License 2.0
15 stars 18 forks source link

Bump ubuntu from 20.04 to 22.04 in /seat_service #80

Closed dependabot[bot] closed 8 months ago

dependabot[bot] commented 1 year ago

Bumps ubuntu from 20.04 to 22.04.

Dependabot compatibility score

Dependabot will resolve any conflicts with this PR as long as you don't alter it yourself. You can also trigger a rebase manually by commenting @dependabot rebase.


Dependabot commands and options
You can trigger Dependabot actions by commenting on this PR: - `@dependabot rebase` will rebase this PR - `@dependabot recreate` will recreate this PR, overwriting any edits that have been made to it - `@dependabot merge` will merge this PR after your CI passes on it - `@dependabot squash and merge` will squash and merge this PR after your CI passes on it - `@dependabot cancel merge` will cancel a previously requested merge and block automerging - `@dependabot reopen` will reopen this PR if it is closed - `@dependabot close` will close this PR and stop Dependabot recreating it. You can achieve the same result by closing it manually - `@dependabot ignore this major version` will close this PR and stop Dependabot creating any more for this major version (unless you reopen the PR or upgrade to it yourself) - `@dependabot ignore this minor version` will close this PR and stop Dependabot creating any more for this minor version (unless you reopen the PR or upgrade to it yourself) - `@dependabot ignore this dependency` will close this PR and stop Dependabot creating any more for this dependency (unless you reopen the PR or upgrade to it yourself)
erikbosch commented 12 months ago

This is good example for our update policy @SebastianSchildt. 22.04 is the latest Ubuntu LTS release, and I think it could be a good policy to use the latest Ubuntu LTS in our Docker containers.

int0x27 commented 12 months ago

It is fixed to ubuntu 20.04 on purpose, in order to produce more compatible binaries. The change affects build scripts, integration, etc. Overall, it is too complex for dependabot to handle.

erikbosch commented 12 months ago

It is fixed to ubuntu 20.04 on purpose, in order to produce more compatible binaries. The change affects build scripts, integration, etc. Overall, it is too complex for dependabot to handle.

I have no real problem if we decide that we stick to a certain target version, but then we should rather state why somewhere. At the moment you cannot by just looking in the repo see if Ubuntu 22.04 was selected as it was "latest and greatest" when the component was created, or if there has been a deliberate decision to use Ubuntu 22.04. At least I could not find it. At least from our CI there does not seem to be a problem updating to 22.04 as all steps pass. If we know that there are problems running Seat Service on Ubuntu 22.04 we should better describe those problems so that we do not forget them.

Concerning compatibility - at least for the Docker image Ubuntu-version should not matter that much?

int0x27 commented 11 months ago

Binaries are build outside of container using ubuntu 20.04: https://github.com/eclipse/kuksa.val.services/blob/00c5dfcf7e57307936c759cceaa3decc6a339c51/.github/workflows/seat_service_build.yml#L27 SeatService Dockerfile just uses them as artifacts. So far it seems they are compatible with latest Ubuntu version, but that is not guaranteed in the future. If dependabot wanted to change build action's Ubuntu version, then integration test would also fail: https://github.com/eclipse/kuksa.val.services/blob/00c5dfcf7e57307936c759cceaa3decc6a339c51/.github/workflows/integration_test.yml#L29

If we decide to move everything on latest Ubuntu, binaries won't work on my VM and generally I prefer to have less binary dependencies.

SebastianSchildt commented 9 months ago

Is the decision here to update or to skip this update? @erikbosch @int0x27

Personally I don't even have any machine with an old 20.04 Ubuntu, on the other hand both are LTS, and 20.04 is still in full support until 2025: https://ubuntu.com/about/release-cycle

Similar question here https://github.com/eclipse/kuksa.val.services/pull/94

If we intend to stay on 20 we can let dependabot close this PRs

erikbosch commented 9 months ago

Is the decision here to update or to skip this update? @erikbosch @int0x27

Personally I don't even have any machine with an old 20.04 Ubuntu, on the other hand both are LTS, and 20.04 is still in full support until 2025: https://ubuntu.com/about/release-cycle

My personal view is that we shall decide on a policy. I do not really buy the argument that 20.04 in general produce "more compatible binaries". I can see some possible policies:

For master/main I think using latest LTS makes sense. That does not prevent that we going forward support multiple branches and add fixes also to a maintenance branch supporting the older Ubuntu-version.

erikbosch commented 8 months ago

Closing all dependabot updates not related to security. I.e. let us update when we see a need for it and have time to test. At least in this repo the CI tests sucks, so they do not say much on whether the component is useful or not

dependabot[bot] commented 8 months ago

OK, I won't notify you again about this release, but will get in touch when a new version is available. If you'd rather skip all updates until the next major or minor version, let me know by commenting @dependabot ignore this major version or @dependabot ignore this minor version.

If you change your mind, just re-open this PR and I'll resolve any conflicts on it.