search

eclipse / kuksa.val.services

Repository for Vehicle Service Related implementations for Eclipse SDV
Apache License 2.0
15 stars 18 forks source link

extends documentation for vehicle mock service #89

Closed eriksven closed 10 months ago

eriksven commented 11 months ago

@doosuu, this PR extends the documentation for the vehicle mock service. Can you check whether the additions still reflect the state of the mock service? For instance, I am not sure whether the vehicle mock service actually uses the kuksa.val.v1 interface of the KUKSA.val databroker. The respective generated classes are part of the service but my IDE could not find any usage of this interface in the mock service.

SebastianSchildt commented 11 months ago

I think we should rebase this on #88 , but that is still inr eview With that PR Mock service is using the KUKSA client lib. That can be reflected iun the diagrams, and/or if still referring to the GRPC interface, it is solely kuksa.val.v1 then, with all the gnerated GRPC files (sdv or kuksa api) references gone

eriksven commented 11 months ago

@doosuu @lukasmittag Thank you for the review. I rebased this PR on #88 and adapted the diagram accordingly so that the Vehicle Mock Service now uses the kuksa.val.v1 interface.

doosuu commented 10 months ago

@eriksven will have another look on this once #88 is merged and the changes in this PR only contain the relevant data.

SebastianSchildt commented 10 months ago

This needs rebase/recreation, can you do it @eriksven? (I think only the Readme has been changed, so maybe just salvage it, reset this branch to master, add it and force push)

eriksven commented 10 months ago

@SebastianSchildt @doosuu I rebased this PR to main after #88 has been merged.