Closed argerus closed 1 year ago
LGTM just one question. Will
filter_map_entries
get used cause currently I see not how it gets used. And just to confirm the adaptions get only used ingrpc/sdv_databroker_v1
because in thegrpc/kuksa_val_v1
the feature is not implemented yet - am I right?
Correct (on both counts). The reason for adding it (filter_map_entries
etc) is that it would have made #641 and similar functionality easier to implement. That PR is already merged, and added very interface specific code to broker.rs
. That code can be moved out to live along the rest of the interface specific code when this PR is merged.
A wrapper function that made it easy to iterate through metadata was already available in the broker interface:
This has been generalized to iterate over entries instead (i.e. not only metadata) as that will be useful when in the
kuksa.val.v1
interface for example: