eclipse / kuksa.val

kuksa.val
Apache License 2.0
89 stars 52 forks source link

Update configuration of python-cli to configuration policy #672

Closed lukasmittag closed 8 months ago

lukasmittag commented 9 months ago

To meet the discussed configuration policy here https://github.com/eclipse/kuksa.val/issues/589 this adds in a first step some environment variables for the cli arguments. Futhermore this should be a place to discuss the removal of default tokens. The default tokens were not used anymore because they got overwritten. This gets fixed with this PR.

The question is do we want to keep default tokens as default usage in or do we just want to keep them in the container that they can manually be used.

@argerus @erikbosch @SebastianSchildt @rafaeling

SebastianSchildt commented 9 months ago

I think remove them, but potentially not necessarily in this PR. @erikbosch as you have reviewed this, you have a better overview, if it is "trivial" or we rather do it separately (I think we would also need to scour documentation, and remove informaton there)

erikbosch commented 9 months ago

I think remove them, but potentially not necessarily in this PR. @erikbosch as you have reviewed this, you have a better overview, if it is "trivial" or we rather do it separately (I think we would also need to scour documentation, and remove informaton there)

Lets do it separately later. Could possibly require some extra work here and there to remove all traces of it.

erikbosch commented 8 months ago

@lukasmittag @SebastianSchildt - Is this a merge candidate to include in v0.4.1?

lukasmittag commented 8 months ago

I think so

erikbosch commented 8 months ago

@lukasmittag - do you want to rebase and fix conflict? So it can be included in 0.4.1

lukasmittag commented 8 months ago

will do

lukasmittag commented 8 months ago

@erikbosch