Closed DanielLazarHTDM closed 4 months ago
Thanks for the PR!
I tried it out quickly, and it seems to be working as intended. Awesome!
I'll get back with a more thorough review. But again, thanks, and welcome (as I think this is your first submission here)!
You are welcome,
Yeah it is my first :) I do have some thoughs about improvent like!
Looking good. I think @argerus if this is not breaking "simple" examples SQL Syntax we might merge this, even if it breaks our "never touch sdv API again", as at least the external interface is not changed.
In the mid/short term we should probably discuss whether we move/copy the "SQL-like query" entrypoint over to kuksa.val.v1 (no equivalent there currently), or maybe out in a separate proto/API, as it is a bit "different style" of interacting with databroker than just the plain get/set/subscribe thingies
Enhancing query engine by:
We will get value if Vehicle.Speed is valid and there is not new feed of this value:
And if there is an change of value query is returning: