Add continuous subscription to subscribe method at a specific frequency

eclipse / kuksa.val

kuksa.val

Apache License 2.0

89 stars 52 forks source link

Add continuous subscription to subscribe method at a specific frequency #734

Open rafaeling opened 4 months ago

rafaeling commented 4 months ago

This PR solves https://github.com/eclipse/kuksa.val/issues/652

How can be tested?

Use this test.json file as the VSS input for the broker. It contains the necessary overlays modified to test it with the ChangeType values Continuous and OnChange to verify the expected behavior test.json
You can subscribe with databroker-clie to the signals Vehicle.Driver.HeartRate (Continuous update) and Vehicle.Body.Trunk.Front.IsLightOn (OnChange update).
Kuksa-client seems to have some bugs that need testing for this new feature.

What to expect?

The value for Vehicle.Driver.HeartRate should be set, as well as for Vehicle.Body.Trunk.Front.IsLightOn.
Subscribe to both paths, and the terminal should display the Continuous values every second and OnChange values only when updated.

Kuksa client to test it https://github.com/eclipse-kuksa/kuksa-python-sdk/pull/21

erikbosch commented 4 months ago

Are you happy with the content of this PR now @argerus ? I.e. is it ready for merge?

argerus commented 4 months ago

Are you happy with the content of this PR now @argerus ? I.e. is it ready for merge?

Probably not. As is currently stands, this PR sets a hard coded update frequency of 1 second for everything, with no way to set it to anything else.

This combined with the fact that we don't include a VSS db with the change types configured, and every signal now defaults to Continuous is probably not the behaviour we want. I do have a version of the VSS db with all change types configured, so perhaps that will make the out of the box behaviour better (if we merge that first).

I still think this PR should include the ability to change the update frequency through the API, otherwise I'm not sure much is gained by merging it.

rafaeling commented 4 months ago

Will then add the frequency parameter to the subscribe request on this PR, was thinking to split it into different PRs but makes no sense.

rafaeling commented 3 months ago

After community call was agreed to avoid changes in VSS and to add the "ChangeType" directly to the subscription request implicitly with the optional frequency parameter.

erikbosch commented 3 months ago

Reopening all PRs closed by accident by boschglobal maintenance

erikbosch commented 2 months ago

Databroker has been migrated to https://github.com/eclipse-kuksa/kuksa-databroker. Please open a new pull request in that repo.