eclipse / kuksa.val

kuksa.val
Apache License 2.0
95 stars 51 forks source link

Removing databroker #769

Closed erikbosch closed 5 months ago

erikbosch commented 5 months ago

As migration is finished no need to keep it here. Version 0.4.3 tagged and docker containers created, verified that they give warnings

erikbosch commented 5 months ago

Anything more you want that we shall do before removing it @SebastianSchildt . I suggest that after you approve it that we ping (or add as reviewer) John, Mike, SvenErik, Lukas, so they are aware that it will be deleted, and can complain before we do it

erikbosch commented 5 months ago

We have used that policy in the past, to remove the code in the old location. Reduces the risk for PRs and Issues in the old repo.

lukasmittag commented 5 months ago

couldn't we keep a branch open like deprecated_databrokeror something like this? Then documenting clearly that it is there and you should not use it. But at least we then keep the state for I do not know end of the year?

erikbosch commented 5 months ago

@lukasmittag - I added a branch https://github.com/eclipse/kuksa.val/tree/deprecated_databroker from previous commit, and references that branch from the README now. So if someone by some reason do not want to use the partially refactored databroker in kuksa-databroker and they want to check out code by branch rather than tag they can use the deprecated_databroker branch.