CQ for Quartz Scheduler

eclipse / kura

Eclipse Kura™ is a versatile framework to supercharge your edge devices, streamlining the process of configuring your gateway, connecting sensors, and IoT devices to seamlessly collect, process, and send data to the cloud.

https://eclipse.dev/kura/

Eclipse Public License 2.0

498 stars 305 forks source link

CQ for Quartz Scheduler #498

Closed amitjoy closed 7 years ago

amitjoy commented 8 years ago

http://www.quartz-scheduler.org

dwoodard1 commented 8 years ago

@amitjoy Are you saying we need to create a CQ for the Quartz scheduler or that it is already done?

amitjoy commented 8 years ago

@dwoodard1 We need to create a CQ for it as the Timer logical block in Kura Wires is using it for extensive functionalities

cdealti commented 8 years ago

It's a 3.2MB jar. Quite heavy.

Cristiano

On 02/09/2016 17:24, Amit Kumar Mondal wrote:

@dwoodard1 https://github.com/dwoodard1 We need to create a CQ for it as the Timer logical block in Kura Wires is using it for extensive functionalities

— You are receiving this because you are subscribed to this thread. Reply to this email directly, view it on GitHub https://github.com/eclipse/kura/issues/498#issuecomment-244406387, or mute the thread https://github.com/notifications/unsubscribe-auth/ABK0a0J76fax30acfvT6yquuucv9AXQEks5qmD-cgaJpZM4JzQI4.

amitjoy commented 8 years ago

@cdealti You just have to file a CQ for quartz-2.2.3.jar (660 KB) and quartz-jobs-2.2.3.jar (34 KB).

cdealti commented 8 years ago

Yes, I've realized that. Of course the SimpleTimer will not need it, right?

Da: Amit Kumar Mondal notifications@github.com Inviato: sabato 3 settembre 2016 09.16.11 A: eclipse/kura Cc: De Alti, Cristiano; Mention Oggetto: Re: [eclipse/kura] CQ for Quartz Scheduler (#498)

@cdealtihttps://github.com/cdealti You just have to file a CQ for quartz-2.2.3.jar (660 KB) and quartz-jobs-2.2.3.jar (34 KB).

You are receiving this because you were mentioned. Reply to this email directly, view it on GitHubhttps://github.com/eclipse/kura/issues/498#issuecomment-244531826, or mute the threadhttps://github.com/notifications/unsubscribe-auth/ABK0a_czgTMdQOWil8THOFNreK7z_Kymks5qmR67gaJpZM4JzQI4.

amitjoy commented 8 years ago

@cdealti We thought of extending the Timer functionalities to incorporate CRON jobs along with basic scheduling functionalities using simple seconds. This would definitely make Timer more powerful and flexible for Industrial IoT Scenarios.

amitjoy commented 7 years ago

@cdealti Would you kindly update this issue with the CQ reference link?

cdealti commented 7 years ago

CQ 12019

cdealti commented 7 years ago

@amitjoy do you have access to [1]?

[1] https://dev.eclipse.org/ipzilla/show_bug.cgi?id=12019

amitjoy commented 7 years ago

I don't think so. I tried to use my usual username and password which I use for Eclipse but that doesn't work for IPZilla.

cdealti commented 7 years ago

Ok, we are required to remove from these sources:

https://github.com/quartz-scheduler/quartz/tree/quartz-2.2.3

all the source code not needed by:

Can you please do that?

Hi Christiano,

I would suggest to avoid any "ahead of time" approvals - your CQ here should only cover what you definitely need, which are the two jars that you mention (imho it is ok to combine them in one CQ here). But the source zip should then also only contain the sources for the classes in these jars. So you should remove all the rest from it, specifially also all tests etc. what is not relevant for the jars.

Regards, Kai

ctron commented 7 years ago

Can't you just attach the maven source attachments?

dwoodard1 commented 7 years ago

I can't find where they have made the source jars available for download, but the build is using the maven-source-plugin. So, if you build the project you should get the source jar. I have found source jars are the best/quickest way for Eclipse to review CQs.

amitjoy commented 7 years ago

Here it goes: https://repo1.maven.org/maven2/org/quartz-scheduler/quartz/2.2.3/

amitjoy commented 7 years ago

@cdealti @MMaiero @dwoodard1 @ctron @LucaDazi Could you kindly assign Kura Wires and CQ labels to this issue? It would be easy to track.

dwoodard1 commented 7 years ago

@amitjoy Thanks! Don't know why I couldn't find it.

cdealti commented 7 years ago

@amitjoy The Quartz CQ [1] Is still pending waiting for the "depopulated" Quartz sources (see my comment above). Can you please prepare this package?

[1] https://dev.eclipse.org/ipzilla/show_bug.cgi?id=12019

amitjoy commented 7 years ago

@cdealti The quartz sources are as follows:

http://search.maven.org/remotecontent?filepath=org/quartz-scheduler/quartz-jobs/2.2.3/quartz-jobs-2.2.3-sources.jar http://search.maven.org/remotecontent?filepath=org/quartz-scheduler/quartz/2.2.3/quartz-2.2.3-sources.jar

MMaiero commented 7 years ago

@amitjoy We can close this, right?

amitjoy commented 7 years ago

@MMaiero Yeah you can. It has already been approved.