search

eclipse / lsp4e

Language Server Protocol support in Eclipse IDE
Eclipse Public License 2.0
57 stars 54 forks source link

Merge org.eclipse.lsp4e.tests.mock plugin into org.eclipse.lsp4e.test #1004

Closed sebthom closed 1 month ago

sebthom commented 1 month ago

This PR moves the org.eclipse.lsp4e.tests.mock classes into the org.eclipse.lsp4e.test plugin. The rational is this:

  1. org.eclipse.lsp4e.tests.mock classes are only used by test cases in org.eclipse.lsp4e.test
  2. the logic of the MockLanguageServer behaviour is tightly coupled to the test cases in org.eclipse.lsp4e.test
  3. org.eclipse.lsp4e.test already provides some mock classes, such as MockConnectionProvider which is confusing why to have two separate plugins each providing only a part of the required mock classes
  4. one plugin less to build/maintain without any loss in runtime functionality

As part of the merge the existing mock classes of the org.eclipse.lsp4e.test plugin are moved from the package org.eclipse.lsp4e.test.utils to package org.eclipse.lsp4e.test.utils.mock together with the mock classes from the org.eclipse.lsp4e.tests.mock plugin.

mickaelistria commented 1 month ago

The initial target branch master was deleted and replaced by main, so this PR got closed automatically. If this is still relevant, please re-create this PR targetting the main branch.