search

eclipse / lsp4e

Language Server Protocol support in Eclipse IDE
Eclipse Public License 2.0
61 stars 54 forks source link

fix: opening file outside of workspace may throw Exception. Fixes #913 #1050

Closed sebthom closed 4 weeks ago

sebthom commented 4 weeks ago

Trying to open an external file located at the root of a filesystem results in:

java.lang.IllegalArgumentException: Path must include project and resource name: /solarized-dark-color-theme.json
    at org.eclipse.core.runtime.Assert.isLegal(Assert.java:66)
    at org.eclipse.core.internal.resources.Workspace.newResource(Workspace.java:2234)
    at org.eclipse.core.internal.resources.Container.getFile(Container.java:196)
    at org.eclipse.lsp4e.LSPEclipseUtils.getFile(LSPEclipseUtils.java:1229)
    at org.eclipse.lsp4e.LSPEclipseUtils.toUri(LSPEclipseUtils.java:371)
    at org.eclipse.lsp4e.operations.codelens.CodeLensProvider.provideCodeMinings(CodeLensProvider.java:34)
    at org.eclipse.lsp4e.operations.codelens.CodeLensProvider.provideCodeMinings(CodeLensProvider.java:66)
    at org.eclipse.jface.internal.text.codemining.CodeMiningManager.lambda$2(CodeMiningManager.java:189)

This PR fixes #913