eclipse / lsp4e

Language Server Protocol support in Eclipse IDE
Eclipse Public License 2.0
61 stars 54 forks source link

Prevent error logging for RequestCancelledExceptions #892

Closed joaodinissf closed 8 months ago

joaodinissf commented 8 months ago

If the language server throws a CancellationException upon cancelling a request, this should not be logged as an error by the LanguageServerPlugin.

A check to ensure this behavior already exists in some locations (e.g., org.eclipse.lsp4e.operations.completion.LSContentAssistProcessor.computeCompletionProposals(ITextViewer, int)).

However, other locations where this check should be performed do not include it. This commit introduces the missing checks.

mickaelistria commented 8 months ago

Thank you!