search

eclipse / lsp4e

Language Server Protocol support in Eclipse IDE
Eclipse Public License 2.0
61 stars 54 forks source link

Add rough sketch for a bugfix for #885 #893

Closed erik-brangs closed 8 months ago

erik-brangs commented 8 months ago

As requested by @mickaelistria in #885 , here is a pull request that highlights where exists() checks might be missing.

The fix is probably wrong because I wasn't actually able to reproduce the problem. The associated test seems to trigger a different problem.

I suppose the original problem is triggered by the order of operations. I don't know enough to reproduce it in a test case.

erik-brangs commented 8 months ago

The test testDiagnosticsForMarkerUpdateAfterProjectClose now reproduces the original problem.

However, I don't know if this fully solves the problem with missing exists() checks. I've added some more exists() checks in other places where errors occurred when trying to write the tests. However, I can't reproduce those reliably. This also applies to the testDiagnosticsForMarkerUpdateAfterDeletedFile test.

The markers rule seems to be null in the tests. Is this normal?