eclipse / lsp4e

Language Server Protocol support in Eclipse IDE
Eclipse Public License 2.0
60 stars 53 forks source link

Master build broken due to failed unit test #930

Closed ghentschke closed 5 months ago

ghentschke commented 5 months ago

The CI build job fails due to a filed unit test:

array lengths differed, expected.length=3 actual.length=0; arrays first differed at element [0]; expected:<StyleRange {0, 4, fontStyle=normal, foreground=Color {133, 153, 0, 255}}> but was:<end of array>

The failed test is https://github.com/eclipse/lsp4e/blob/78fffa519b11b5c56bcc612e5133a4cef8adfb95/org.eclipse.lsp4e.test/src/org/eclipse/lsp4e/test/semanticTokens/SemanticHighlightReconcilerStrategyTest.java#L51

ghentschke commented 5 months ago

Has anyone an idea why this test is now failing?

mickaelistria commented 5 months ago

@ghentschke Can you reproduce the failure locally? Can you find the offending change that has triggered it?

ghentschke commented 5 months ago

Yes, I can reproduce it on my machine. I'll take a look.

ghentschke commented 5 months ago

This test failure has been caused by a commit in tm4e. I opened this tm4e issue, but I am not sure if its should be fixed in tm4e or in lsp4e.

ghentschke commented 5 months ago

It could be fixed in lp4e by #940

ghentschke commented 5 months ago

Fixing one issue and two others popping up. This unit test seems to be flaky. They fail with Widget is disposed error.