search

eclipse / lsp4e

Language Server Protocol support in Eclipse IDE
Eclipse Public License 2.0
60 stars 53 forks source link

Fixed #958 Add ID to menu to allow external contributions #959

Closed ylussaud closed 4 months ago

ylussaud commented 4 months ago

I made some refactoring commands server side and want to contribute them in Eclipse (client) side. For the moment I made the contribution to my own menu, but it would make more sens to contribute to existing LSP4E menus. And I guess others might be interested as well.

The Refactorings menu is contributed by LSP4E and I'm contributing refactoring commands... But for other commands I will have a look at menus contributed by the Generic Editor.

mickaelistria commented 4 months ago

I think on longer term, it would be better to have the Source & Refactorings menus contributed by the Generic Editor correctly as any code editor is likely to want those, and LSP4E just feeding them.

ylussaud commented 4 months ago

Yes that make sens.

mickaelistria commented 4 months ago

If you want to lead this effort and contribute those menus to generic editor, please feel free, that would be very welcome!

ylussaud commented 4 months ago

I opened the following issue for the Generic Editor.

BTW the Generic Editor already provides a source menu: org.eclipse.ui.genericeditor.source.menu.