search

eclipse / lsp4e

Language Server Protocol support in Eclipse IDE
Eclipse Public License 2.0
60 stars 53 forks source link

TokenType is 0 based according to LSP spec #964

Closed BoykoAlex closed 4 months ago

rubenporras commented 4 months ago

Hi @BoykoAlex ,

Is it correct that this is a similar change to the one done in the recent Xtext 2.34 (https://github.com/eclipse/xtext/pull/2753, see changes to org.eclipse.xtext.ide/src/org/eclipse/xtext/ide/server/semantictokens/SemanticTokensService.java).

Also, out of curiosity, are you using an Xtext-based language server, or have you discovered the issue with a different type of server?

Regards

BoykoAlex commented 4 months ago

@rubenporras yes, looks like it is the same kind of change to me.

No, not using XText, at least at the moment. There are JPA Queries that are typically embedded in annotations inside Java code. Therefore, we decided to provide semantic highlighting for query strings inside Java annotations. This is implemented as part of the Spring Boot Language server. The clients are LSP4E and vscode-languageclient. The work is tracked by https://github.com/spring-projects/sts4/issues/1114.

I have to admit highlighting is somewhat unknown territory for me... so I had some additional questions here #965