search

eclipse / lsp4e

Language Server Protocol support in Eclipse IDE
Eclipse Public License 2.0
62 stars 54 forks source link

Fix race condition in LanguageServerWrapper resulting in NullPointerException during LS initialization #985

Closed sebthom closed 5 months ago

sebthom commented 5 months ago

When running the test suite on Windows and in Docker with Ubuntu, a lot of NPEs with the following stacktrace are thrown:

java.lang.NullPointerException: Cannot invoke
"org.eclipse.core.runtime.IProgressMonitor.done()" because
"this.this$0.initializeFutureMonitor" is null
    at org.eclipse.lsp4e.LanguageServerWrapper$2.run(LanguageServerWrapper.java:407)
    at org.eclipse.core.internal.jobs.Worker.run(Worker.java:63)

and because of the NPE random tests seem to fail.

mickaelistria commented 5 months ago

The tests failures are all related?

sebthom commented 5 months ago

No, we are getting random OOMs for builds since 26th of April https://ci.eclipse.org/lsp4e/job/lsp4e-github/job/PR-975/4/. No idea why. I opened a ticket but they say it must be a config change in our build process.

sebthom commented 5 months ago

@mickaelistria @rubenporras any objections to merge this?