eclipse / lsp4jakarta

Language Server for Jakarta EE
Eclipse Public License 2.0
34 stars 51 forks source link

Externalize hard coded strings to properties files #309

Open kathrynkodama opened 2 years ago

kathrynkodama commented 2 years ago

Set up framework and externalize existing strings

bensonnw commented 2 years ago

Framework for both Jakarta LS and Jakarta JDT LS components:

One thing unknown:

We are using JSON file for code completion in Jakarta LS, messages and action details are all defined there, we need a way to handle those messages differently

bensonnw commented 2 years ago

Loading JSON files:

  1. JakartaEESnippetRegistryLoader loads each JSON file and adds the contents to SnippetRegistry
  2. SnippetRegistry.getCompletionItem(...) to create org.eclipse.lsp4j.CompletionItem object for code completion
TrevCraw commented 2 years ago

New issue open to address creating the Java framework for globalization: https://github.com/eclipse/lsp4jakarta/issues/315

This issue will focus on adding the JSON piece of the framework and externalizing existing strings.

turkeylurkey commented 1 year ago

Modifying the messages and locations requires updates in liberty-tools-intellij https://github.com/OpenLiberty/liberty-tools-intellij/issues/453

turkeylurkey commented 1 year ago

Externalized messages for diagnostics and quick fixes but not snippets.