Fix osgi.ee=UNKNOWN capability requirement

[berezovskyi]

Description

p2-maven-plugin since 1.7.0 correctly detects the bytecode level using latest JDKs again

Checklist

• [x] This PR adds an entry to the CHANGELOG. _See https://keepachangelog.com/en/1.0.0/ for instructions. Minor edits are exempt.
• [ ] This PR expects some manual changes to the generated code. The needed changes are detailed in the CHANGELOG entry.
• [x] This PR was tested with at least one code generation, resulting in a working OSLC server. Having Acceleo problems, see below
• [x] This PR does NOT break the user block code

Issues

Closes #0; Closes #00

(use exactly this syntax to link to issues, one issue per statement only!)

[berezovskyi]

We still have a minor problem with versions but at least LyoD runs now:

We will need to investigate the first problem and the rest I am thinking it's due to the mismatch of the RCP and Orbit P2 repos (I did not pull your changes today to update RCP from 2020-09 to 2021-03 to match the Orbit version).

[jadelkhoury]

we are packaging com.google.gson_2.9.0.jar

See https://download.eclipse.org/lyo/bundle/p2/edge/plugins/

[jadelkhoury]

I tested this branch with older versions of the plugins (see pic below), and it ran fine. I then upgraded to the latest bundles, but then I got many "missing osgi-ee" (see 2nd pic below).

I am running on Eclipse 2020-12. Maybe time to run on a later eclipse as well?

[jadelkhoury]

In the last commit, I change the build to be bsaed on Eclipse 2021-09. This results in following instead

[jadelkhoury]

With the last commit:

1. I build the bundles using 2022-03
2. I run from Eclipse 2022-03 Now we are down to the problem with Gson version only. But interestingly, both gson versions are in the workspace. So why are they complaining really?

[jadelkhoury]

@berezovskyi ! I cannot add you as a reviewer, but I have a working solution. Can you please review to see what changes I made? Please note that this upgrades LyoD to use eclipse 2022-03! It also means we will upgrade to latest version of Sirius and Acceleo. (Maybe it was not necessary, but might as well)

The mail problem is that we need to build Lyod based on the bundles we construct within that same build (and not what is under https://download.eclipse.org/lyo/bundle/p2/edge/

[jadelkhoury]

I've already tested, but please do to double check if you want.

[jadelkhoury]

@berezovskyi please note that I made a new commit. The I removed were needed, otherwise I cannot run LyoD from source.

[jadelkhoury]

Fails to build https://ci.eclipse.org/lyo/job/lyo-designer-test/55/console

Test locally again: things work as expected since "org.eclipse.lyo.oslc4j.plugins\target\repository" existed. But if I delete the "target" folder, things fail.

But this strange since "clean package" should have deleted the target folder. Maybe some checks are run before the "clean" is being run.

If we can somehow can keep the file "org.eclipse.lyo.oslc4j.plugins\target\repository\content.jar", we can break this loop.

[jadelkhoury]

And now I can build on Jenkins, by introducing a new mvn build step that simply builds the "plugins" module first (everything else is then rebuilt again) See https://ci.eclipse.org/lyo/job/lyo-designer-test/configure

New exe from: https://download.eclipse.org/lyo/product/binaries/superedge/

Update existing installation with: https://download.eclipse.org/lyo/product/p2/superedge

[berezovskyi]

Looks good to me, let's merge! See the next message.

Did I understand you right that you want to change file:org.eclipse.lyo.oslc4j.plugins/target/repository somehow? I think I actually like this approach better as it's more deterministic.

FYI, I still have the UNKNOWN warning about a JSON-LD library (though everything seems to work at runtime):

[berezovskyi]

Actually, in the CI build, Equinox (during a Tycho build) complains that "file:org.eclipse.lyo.oslc4j.plugins/target/repository: URI is not hierarchical".

[berezovskyi]

Just updated the Github Action to match the build steps in Eclipse Jenkins.

[jadelkhoury]

FYI, I still have the UNKNOWN warning about a JSON-LD library (though everything seems to work at runtime):

From the exe files you downloaded? Or building your own? If building your own, are you using 2022-03?

[jadelkhoury]

Actually, in the CI build, Equinox (during a Tycho build) complains that "file:org.eclipse.lyo.oslc4j.plugins/target/repository: URI is not hierarchical".

Can you share a link to see where? If this happens, it means it is not building correctly. This should mean the exe won't work. But it does!!!

[berezovskyi]

If building your own, are you using 2022-03?

Running from the source, Eclipse 2022-03.

Can you share a link to see where? If this happens, it means it is not building correctly. This should mean the exe won't work. But it does!!!

That's not a problem on my machine but instead on the CI from Github Actions. It was showing PR as failing to build. I added a build step for the bundles, copying what you did in the Jenkins build and now it works well: f240063 (#252)